?

Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
17 Oct 2019

Pull Request for Issue # .

Summary of Changes

This removes FieldsHelper::countItems() method. The method calls parent method but the class has no parent. This causes a deprecation notice on PHP 7.4:

Deprecated: Cannot use "parent" when current class scope has no parent

And using the method causes a fatal error on all PHP versions:

Fatal error: Uncaught Error: Cannot access parent:: when current class scope has no parent

Testing Instructions

Code review.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 17 Oct 2019
avatar SharkyKZ SharkyKZ - change - 17 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2019
Category Administration com_fields
avatar SharkyKZ SharkyKZ - change - 25 Oct 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 30 Oct 2019

Thanks for the cleanup

avatar HLeithner HLeithner - change - 30 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-30 08:59:16
Closed_By HLeithner
avatar HLeithner HLeithner - close - 30 Oct 2019
avatar HLeithner HLeithner - merge - 30 Oct 2019

Add a Comment

Login with GitHub to post a comment