?

Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
17 Oct 2019

Partial Pull Request for Issue #26607.

Summary of Changes

get_magic_quotes_gpc() emits a deprecation notice on PHP 7.4:

Deprecated: Function get_magic_quotes_gpc() is deprecated

This suppresses the notice.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 17 Oct 2019
avatar SharkyKZ SharkyKZ - change - 17 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2019
Category Administration com_joomlaupdate External Library Libraries
avatar SharkyKZ SharkyKZ - change - 17 Oct 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 17 Oct 2019
avatar HLeithner
HLeithner - comment - 17 Oct 2019

just remove this function it always returns false since php 5.4

avatar HLeithner
HLeithner - comment - 17 Oct 2019

ah forget this ;-) j3 please make a php version check suppressing error messages are a bad idea.

avatar SharkyKZ SharkyKZ - change - 17 Oct 2019
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 17 Oct 2019

Added version check.

avatar euismod2336 euismod2336 - test_item - 19 Oct 2019 - Tested successfully
avatar euismod2336
euismod2336 - comment - 19 Oct 2019

I have tested this item successfully on 758aa85

## in php >= 5.4 the get_magic_quotes_gpc will no longer be reached


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26615.

avatar AngermannMarkus AngermannMarkus - test_item - 19 Oct 2019 - Tested successfully
avatar AngermannMarkus
AngermannMarkus - comment - 19 Oct 2019

I have tested this item successfully on 758aa85

tested with a fresh joomla 3.9.12 with an old php5.6.38, changed all three files without failures.
done a component-joomla update, also without failure.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26615.

avatar HLeithner HLeithner - close - 19 Oct 2019
avatar HLeithner HLeithner - merge - 19 Oct 2019
avatar HLeithner HLeithner - change - 19 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 13:41:09
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 19 Oct 2019

thx

Add a Comment

Login with GitHub to post a comment