NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
12 Oct 2019

Pull Request for Issue #26536

Summary of Changes

Use the show class to allow the menu to be closed when opening another menu

Testing Instructions

  1. Compile the JS
  2. Login to the backend
  3. Open a menu and select an item
  4. Now the menu that you opened is open by default, click another toplevel menu
  5. The active menu should be closed and the clicked menu open

Expected result

The only open menu is the one clicked

Not sure if this is what the expected outcome is as no desired outcome is mentioned in issue #26536

Actual result

There are 2 open menus, the one clicked and the active menu

Documentation Changes Required

None

@infograf768 @brianteeman

avatar roland-d roland-d - open - 12 Oct 2019
avatar roland-d roland-d - change - 12 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2019
Category JavaScript Repository NPM Change
avatar infograf768 infograf768 - test_item - 12 Oct 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 12 Oct 2019

I have tested this item successfully on 8d63bdb

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26560.

avatar alikon alikon - test_item - 12 Oct 2019 - Tested successfully
avatar alikon
alikon - comment - 12 Oct 2019

I have tested this item successfully on 8d63bdb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26560.

avatar alikon alikon - change - 12 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 12 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26560.

avatar infograf768 infograf768 - change - 12 Oct 2019
Title
Change class to allow closing of menus when opening another
[4.0] Change class to allow closing of menus when opening another
avatar infograf768 infograf768 - edited - 12 Oct 2019
avatar brianteeman brianteeman - test_item - 12 Oct 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Oct 2019

I have tested this item successfully on 8d63bdb

Thanks - tested on mobile and desktop


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26560.

avatar rdeutz rdeutz - change - 12 Oct 2019
Labels Added: NPM Resource Changed ? ?
avatar wilsonge wilsonge - close - 12 Oct 2019
avatar wilsonge wilsonge - merge - 12 Oct 2019
avatar wilsonge wilsonge - change - 12 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-12 16:40:48
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment