User tests: Successful: Unsuccessful:
Pull Request for Issue # .
build/build-modules-js/utils/rootpath.es6.js
with const RootPath = process.cwd();
build/build-modules-js/utils/make-dir.es6.js
with https://www.npmjs.com/package/fs-extra (18 million d/ls per week)build/build-modules-js/utils/walk-sync.es6.js
with https://www.npmjs.com/package/walk-sync (1/2 million d/ls per week)Run npm i
etc. Still get all the files in the media and templates
NO
When I was writing the build tools was extremely cautious to the number of dependencies that were required as I thought the less the faster the CI. In the meantime the project added quite a few more dependencies so it makes zero sense to keep the build tools lean if the same mentality is not shared across the board. Most importantly and quite honestly it should solve a problem on my other PR
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
@C-Lodder mkdirp
Is creating all the given folders recursively. About permissions I was thinking how that thing will possibly react in the windows system but since I don’t do dos anymore I decided to leave the mode as is. You can test this with mode: 0644
And let me know
Check my template repo. Comitted something yesterday to build the folders recursively using FS
Labels |
Added:
NPM Resource Changed
?
|
Shame Node don't use fs-extra
natively. fs
has some very annoying flaws in it :/
@brianteeman can you give this a quick run when you have a minute to ensure this still works on windows please
Will do after the
@SniperSister @rdeutz can you guys have a look at the ATT why drone isn't triggering for the last 2 builds of this PR please
Title |
|
@wilsonge npm i ran fine on windows. even seemed to be faster than before. Only thing to note is the following. No idea if its related to this PR or not so posting it
npm WARN acorn-dynamic-import@4.0.0 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ajv-keywords@3.2.0 requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN sass-loader@5.0.1 requires a peer of webpack@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN com_media@4.0.0 No repository field.
@brianteeman yes somehow we need to remove the node_modules in administrator/com_media. I can do it here or spin another PR
Just quick because ....
The volume cache plugin reacts to special directives in a commit message to provide additional functionality. Include one of the following directives somewhere in your commit message to trigger their respective actions:
[CLEAR CACHE]
instruct the plugin to clear the entire cache. This only influences the restoring step, the plugin will still rebuild cache if instructed to do so.
[NO CACHE]
instruct the plugin not to restore or rebuild cache for this build.
Title |
|
Title |
|
@dgrammatiko looks like a legit drone failure now
Title |
|
But ESLint exists in the package.json
It's mkdirp
that's missing from the dependencies according to the error?
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-17 10:23:37 |
Closed_By | ⇒ | wilsonge |
Thanks!
Why use
mkdirp
overfs
(native)?Just an FYI, you're creating directories with
0777
chmod permissions. Doesn't Joomla use0755
?