? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Oct 2019

Following the advice from chromium

You can help ensure that browsers' and extensions' password management functionality can understand your site's sign-up, sign-in and change-password forms by enriching your HTML with a dash of metadata.

This PR basically changes most autocomplete=off to new-password or current-password as appropriate and if relevant to username

PR #26467 is required

avatar brianteeman brianteeman - open - 6 Oct 2019
avatar brianteeman brianteeman - change - 6 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2019
Category Administration com_users Modules Front End Installation
avatar Quy
Quy - comment - 6 Oct 2019

Related PR #23913?

avatar brianteeman
brianteeman - comment - 6 Oct 2019

@Quy almost except this one works. It would not work without 26467

avatar Quy
Quy - comment - 6 Oct 2019

OK to close the other PR?

avatar Quy
Quy - comment - 10 Oct 2019

Please fix conflicts.

avatar brianteeman brianteeman - change - 13 Oct 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 Oct 2019

conflicts fixed

avatar Quy Quy - test_item - 13 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 13 Oct 2019

I have tested this item successfully on 6d44675


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

avatar uthorat uthorat - test_item - 19 Oct 2019 - Tested successfully
avatar uthorat
uthorat - comment - 19 Oct 2019

I have tested this item successfully on 6d44675


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

avatar Quy Quy - change - 19 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

avatar HLeithner HLeithner - change - 19 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 09:47:05
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 19 Oct 2019
avatar HLeithner HLeithner - merge - 19 Oct 2019
avatar HLeithner
HLeithner - comment - 19 Oct 2019

thx

avatar brianteeman
brianteeman - comment - 19 Oct 2019

Thanks

Add a Comment

Login with GitHub to post a comment