Feeling Lucky
?
[#26493] - [4.0] [ModuleHelper] Check nullable datetime columns for real NULL values
- Fixed in Code Base
- 9 Oct 2019
- Medium
- Build: 4.0-dev
- # 26493
- Diff
- richard67:4.0-dev-module-helper-nullable-datetimes
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue PR #21901 - follow up.
Summary of Changes
This PR replaces the checks of published up and down times of the module table for null dates by checks for real NULL values in SQL.
These database columns have been made nullable with PR #21901 .
Testing Instructions
Can be merged by review.
Expected result
Modules work as well as before.
Actual result
Modules work.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
alikon
- comment
- 7 Oct 2019
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26493.
alikon
- comment
- 7 Oct 2019
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26493.
SharkyKZ
- comment
- 8 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26493.
| Status | Pending | ⇒ | Ready to Commit |
SharkyKZ
- comment
- 8 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26493.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-09 22:29:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 9 Oct 2019
Thanks!
Ping @wilsonge?