• Closed
• 6 Dec 2013
• Medium
• Build: master
•   # 2648
•   Diff
•   Bakual:FixEditGlobalLayout
• Foreign ID 32889

• Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

Bakual
5 Dec 2013

Issue

The "Version Note" field for the content versioning is shown in each extension regardless of the component settings.

Bug description

This is due to a bug in the joomla.edit.global JLayout file which checks the component parameters based on the extension instead of the option.

Proposed Fix

The PR will fix this by first checking for the option, and if this is 'com_categories' it will look up the extension instead and take only the first part of it (because the second may be a section, like "com_content.other").

Testing

1. Enable Version History in com_content
2. Diable Version History in com_contact
3. Edit a contact and see that the "Version Note" field still shows.
4. Disable Version History in com_content
5. "Version Note" is no longer shown
6. Enable Version History in com_contact
7. "Version Note" still doesn't show.
8. Apply patch and make sure everything works now as expected (including categories).

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32889

e4e57d0 5 Dec 2013 Fixing component parameter lookup in global edit JLayout.

Bakual - open - 5 Dec 2013

Bakual - change - 6 Dec 2013

The description was changed

Description	<h3>Issue</h3> <p>The "Version Note" field for the content versioning is shown in each extension regardless of the component settings.</p> <h3>Bug description</h3> <p>This is due to a bug in the joomla.edit.global JLayout file which checks the component parameters based on the <code>extension</code> instead of the <code>option</code>.</p> <h3>Proposed Fix</h3> <p>The PR will fix this by first checking for the option, and if this is 'com_categories' it will look up the extension instead and take only the first part of it (because the second may be a section, like "com_content.other").</p> <h3>Testing</h3> <ol> <li>Enable Version History in com_content</li> <li>Diable Version History in com_contact</li> <li>Edit a contact and see that the "Version Note" field still shows.</li> <li>Disable Version History in com_content</li> <li>"Version Note" is no longer shown</li> <li>Enable Version History in com_contact</li> <li>"Version Note" still doesn't show.</li> <li>Apply patch and make sure everything works now as expected (including categories).</li> </ol>	⇒	<h3>Issue</h3> <p>The "Version Note" field for the content versioning is shown in each extension regardless of the component settings.</p> <h3>Bug description</h3> <p>This is due to a bug in the joomla.edit.global JLayout file which checks the component parameters based on the <code>extension</code> instead of the <code>option</code>.</p> <h3>Proposed Fix</h3> <p>The PR will fix this by first checking for the option, and if this is 'com_categories' it will look up the extension instead and take only the first part of it (because the second may be a section, like "com_content.other").</p> <h3>Testing</h3> <ol> <li>Enable Version History in com_content</li> <li>Diable Version History in com_contact</li> <li>Edit a contact and see that the "Version Note" field still shows.</li> <li>Disable Version History in com_content</li> <li>"Version Note" is no longer shown</li> <li>Enable Version History in com_contact</li> <li>"Version Note" still doesn't show.</li> <li>Apply patch and make sure everything works now as expected (including categories).</li> </ol><h4>Tracker</h4> <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&amp;tracker_item_id=32889">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&amp;tracker_item_id=32889</a></p>
Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2013-12-06 17:39:57
Labels	Added: ? ?

Bakual - close - 6 Dec 2013

Add a Comment

• Older
• Newer