User tests: Successful: Unsuccessful:
Pull Request for Issue # .
#19048
cleaned all paths to ensure platform proper styling with no mixed platform cases.
no extra '/' in path
put preceding '/' in file in HTMLHelper:: call like below..
if($customCSS){ HTMLHelper::_('stylesheet', '/custom.css', $HTMLHelperOptions); }
'<link'> or <script> is created with proper pathing
// between base and filename.
Mixed case of / and \ in path
none.
Sorry to have to keep redoing this.. I suck @ git!
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
if($customCSS){ HTMLHelper::_('stylesheet', '/custom.css', $HTMLHelperOptions); }
That obviously won't work as a single line as the variables are unique to your template and not part of core.
Instead I modified this line protostar
JHtml::_('stylesheet', 'user.css', array('version' => 'auto', 'relative' => true));
to
JHtml::_('stylesheet', '/user.css', array('version' => 'auto', 'relative' => true));
and created a user.css file in the template css folder
After doing that (on my windows system) I can see what I think you are reporting when I view the source
<link href="/cms/templates/protostar/css//custom.css?3b6e1177ff1cdf549f0087a26d714809" rel="stylesheet" />
But that double slash is not a problem and doesnt prevent custom.css file being loaded. And applying the code change made no difference to the //
In summary I don't believe the problem you experienced is related to this at all
@brianteeman Clearly the variable was an example, especially considering I said "like" below.
As for the issue it may have been cured in the 2yrs since I initially created the issue/pr.. I'll test for the issue again this morning.
Labels |
Added:
?
|
Please provide a clear example that can be used to show the problem you are trying to solve.
I have honestly no idea what you were doing with your last commit but its now virtually impossible to see what the code is that you changed - plus there is no way that the changes here are an improvement in any way.
/me cant help but feel you are wasting your time on a non-issue
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-15 19:51:25 |
Closed_By | ⇒ | N6REJ |
@viocassel would you retest please if needed.
@brianteeman I triple checked there is only one file this time.