[#26294] - clean path in HTMLHelper:: & prevent duplicate /
- Closed
- 14 Sep 2019
- Medium
- Build: staging
- # 26294
- Diff
- N6REJ:19048
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
#19048
Summary of Changes
cleaned all paths to ensure platform proper styling with no mixed platform cases.
no extra '/' in path
Testing Instructions
put preceding '/' in file in HTMLHelper:: call like below..
if($customCSS){ HTMLHelper::_('stylesheet', '/custom.css', $HTMLHelperOptions); }
Expected result
'<link'> or <script> is created with proper pathing
Actual result
// between base and filename.
Mixed case of / and \ in path
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Modules Front End |
| Title |
|
||||||
crap crap crap...
yep, I knew that, forgot to switch back first.. I'll fix it right away.
| Labels |
Added:
?
|
||
@brianteeman it's weird cause I was sure I was careful ( and I was N6REJ@e1baf5f ) but I see what your saying.
Did I fix it right?
Did I fix it right?
Look on github - you can see that you did not
@brianteeman I did look but now its an even bigger mess sigh.. I'm closing thing then redoing it... YET AGAIN...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-14 18:04:47 |
| Closed_By | ⇒ | N6REJ |
Why would you add a leading slash in the first place though?
valid point but I've seen it done with the previous method that most are used to. I'd say its more proactive then necessary.
I have tested this item✅ successfully on e1baf5f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26294.