[#26293] - [4.0] Add fallback for not complete manifest caches used in the pre-update checker
- Fixed in Code Base
- 11 Jan 2020
- Medium
- Build: 4.0-dev
- # 26293
- Diff
- zero-24:updater_notice
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22421 (comment) reported by @infograf768
Summary of Changes
Add fallback for not complete manifest caches used in the pre-update checker
Testing Instructions
.- install 4.0-dev
- install patchtester
- go to the database and clear the field
manifest_cachefor the patchtester record in the extensions table. - set the nightly major update server
- notice the pre update checker
- notice that the pre update checker shows nothing as version for the patchtester and raises a notice
- apply this patch
- the updater now shows the string `Unknown version in this case and should not raise and notice any more.
Expected result
No errors; After the patch the pre-update checker shows Unknown version before that info was just missing / empty.
Actual result
Notice: Trying to get property 'version' of non-object in .../administrator/components/com_joomlaupdate/Model/UpdateModel.php on line 1357
And an empty version info for that extension.
Additional steps
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings |
| Labels |
Added:
?
?
|
||
Will you do another PR for the following?
PHP Notice: Trying to get property 'version' of non-object in \administrator\components\com_installer\Model\DatabaseModel.php on line 490
@zero-24
We have also
Notice: Undefined property: stdClass::$version in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_installer/tmpl/manage/default.php on line 108
Notice: Undefined property: stdClass::$version in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_installer/tmpl/manage/default.php on line 124
This shows in Extensions=>Manage for the Sample Data Testing plugin
These means that we may need a more general string for "Unknown version" as it can be used with exactly the same value in com_installer, including for this PR. Maybe JGLOBAL_UNKNOWN_VERSION="Unknown Version"
@infograf768 Go to System > Update > Joomla > Pre-Update Check
Well the deeper problem is why is the manifest cache not up-to-date, has this been reproduced in a live site too? This is just a hot fix not fixing the real cause of the problem.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26293.
I have tested this item
#pbf19 #test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26293.
| Status | Pending | ⇒ | Ready to Commit |
Can you fix conflicts please?
| Labels |
Added:
?
|
||
Done @wilsonge thanks @richard67
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-11 17:13:15 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 36dd0e7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26293.