Conflicting Files ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
11 Sep 2019

Successor PR to #26250

  • Moves to promises per TODO
  • Fixes bug where if token check failed the request still proceeded
  • Simplifies installation logic
  • Moves to promises/fetch in part of the installer (supported by all required browsers)

Testing Instructions

Start a joomla 4 installation
In the "databse configuration"-tab enter incorrect database credentials
Click on the "Setup Database Connection" button
Now you should get a view, similar to the screenshot above
Now apply my patch
Retry the installation with incorrect database credentials
Now you should get a view where only the "Database Configuration"-Tab is shown

Expected result

Only database tab shown for corrections

Actual result

All installation Tabs are shown. (See screenshot above in PR #26250)

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 11 Sep 2019
avatar wilsonge wilsonge - change - 11 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2019
Category Installation JavaScript
avatar richard67 richard67 - test_item - 11 Sep 2019 - Tested successfully
avatar richard67
richard67 - comment - 11 Sep 2019

I have tested this item successfully on 6db2cdd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26265.

avatar C-Lodder
C-Lodder - comment - 11 Sep 2019

If I rightly remember, Babel doesn't transpile promises unless you're using their polyfill, which I don't think Joomla does

avatar richard67
richard67 - comment - 11 Sep 2019

@C-Lodder Is installation/template/js/setup.js transpiled, too? I've never noticed that.

avatar richard67
richard67 - comment - 11 Sep 2019

As far as I can see, only stuff below build/media_source is transpiled, to which the installation setup.js does not belong. So for this PR here it seems to be ok.

avatar C-Lodder
C-Lodder - comment - 11 Sep 2019

@richard67 I think it's separate, but @wilsonge requested that ES2013 JS stayed as part of the CMS to support IE11, and Promises are not part of that spec

avatar richard67
richard67 - comment - 11 Sep 2019

@C-Lodder I see. Well, maybe George changed opinion ;-) But good that you remind him.

avatar richard67
richard67 - comment - 11 Sep 2019

@C-Lodder Well, I just remember IE11 stuff mainly should be kept for 3rd party devs, not for core install, so maybe that's the reason why he uses the promises here.

But I think it could be dangerous: Some people might see it as example which could be used anywhere else and then use it where it should not be used. No idea what's the result if such thing is then transpiled, best would be to have an error, worst would be that it just does nothing.

So I think it is good that you mentioned it here.

avatar wilsonge
wilsonge - comment - 12 Sep 2019

I dunno. I mean I hadn’t considered whether the installation should work on IE11 if I’m brutally honest. My gut is it shouldn’t. I’m mostly caring about the front end templates (not even the backend). But willing to listen as to if we should just blanket require Babel (currently we aren’t even running Babel or scss on the installer)

avatar brianteeman
brianteeman - comment - 12 Sep 2019

It probably should work just enough to get to a page that says you cant use ie11 and you need to use one of the other browsers that you have on your machine - and not end up like the login screen which is just blank

avatar C-Lodder
C-Lodder - comment - 13 Sep 2019

Ok. In which case you just need to fix the code style

avatar infograf768 infograf768 - change - 13 Sep 2019
Labels Added: ?
avatar nadjak77
nadjak77 - comment - 19 Oct 2019

after applying the patch I cannot install joomla.
I have the following error :
image

avatar fotisoikonomou
fotisoikonomou - comment - 19 Oct 2019

Issue #26265 is not resolved.
Applying wrong database credentials does not appears the expected error message.
Instead, it proceeds with the validation of the database and the installation process.

#26265 instawrong

avatar richard67
richard67 - comment - 19 Oct 2019

@fotisoikonomou Did you test with the right order of processing? You first have to apply this patch on a 4.0-dev branch of a git clone, or you have to apply it on a 4.0-alpha-12 or nightly build installation, then delete configuration.php and all database tables using PhpMyAdmin or whatever else, then make a new installation with the patched code.

avatar webfeuerflo webfeuerflo - test_item - 19 Oct 2019 - Tested successfully
avatar webfeuerflo
webfeuerflo - comment - 19 Oct 2019

I have tested this item successfully on ca6a552

After adding the missing { in setup.js the patch works and I can only see the db connection tab to correct the connection


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26265.

avatar roland-d
roland-d - comment - 1 Aug 2020

@wilsonge Please fix the conflicts

avatar laoneo laoneo - change - 6 Apr 2022
Labels Added: ?
Removed: ?
avatar laoneo
laoneo - comment - 6 Apr 2022

@wilsonge can you have a look on the conflicts? Should also be rebased to 4.2-dev I guess.

avatar wilsonge wilsonge - change - 20 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-20 22:35:52
Closed_By wilsonge
avatar wilsonge wilsonge - close - 20 Jun 2022
avatar wilsonge
wilsonge - comment - 20 Jun 2022

These conflicts are basically unfixible. If someone wants to pick this up then I'm happy with it

Add a Comment

Login with GitHub to post a comment