User tests: Successful: Unsuccessful:
Successor PR to #26250
Start a joomla 4 installation
In the "databse configuration"-tab enter incorrect database credentials
Click on the "Setup Database Connection" button
Now you should get a view, similar to the screenshot above
Now apply my patch
Retry the installation with incorrect database credentials
Now you should get a view where only the "Database Configuration"-Tab is shown
Only database tab shown for corrections
All installation Tabs are shown. (See screenshot above in PR #26250)
None
Status | New | ⇒ | Pending |
Category | ⇒ | Installation JavaScript |
If I rightly remember, Babel doesn't transpile promises unless you're using their polyfill, which I don't think Joomla does
As far as I can see, only stuff below build/media_source
is transpiled, to which the installation setup.js does not belong. So for this PR here it seems to be ok.
@richard67 I think it's separate, but @wilsonge requested that ES2013 JS stayed as part of the CMS to support IE11, and Promises are not part of that spec
@C-Lodder Well, I just remember IE11 stuff mainly should be kept for 3rd party devs, not for core install, so maybe that's the reason why he uses the promises here.
But I think it could be dangerous: Some people might see it as example which could be used anywhere else and then use it where it should not be used. No idea what's the result if such thing is then transpiled, best would be to have an error, worst would be that it just does nothing.
So I think it is good that you mentioned it here.
I dunno. I mean I hadn’t considered whether the installation should work on IE11 if I’m brutally honest. My gut is it shouldn’t. I’m mostly caring about the front end templates (not even the backend). But willing to listen as to if we should just blanket require Babel (currently we aren’t even running Babel or scss on the installer)
It probably should work just enough to get to a page that says you cant use ie11 and you need to use one of the other browsers that you have on your machine - and not end up like the login screen which is just blank
Ok. In which case you just need to fix the code style
Labels |
Added:
?
|
@fotisoikonomou Did you test with the right order of processing? You first have to apply this patch on a 4.0-dev branch of a git clone, or you have to apply it on a 4.0-alpha-12 or nightly build installation, then delete configuration.php and all database tables using PhpMyAdmin or whatever else, then make a new installation with the patched code.
I have tested this item
After adding the missing { in setup.js the patch works and I can only see the db connection tab to correct the connection
Labels |
Added:
?
Removed: ? |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-20 22:35:52 |
Closed_By | ⇒ | wilsonge |
These conflicts are basically unfixible. If someone wants to pick this up then I'm happy with it
I have tested this item✅ successfully on 6db2cdd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26265.