Feeling Lucky
?
[#26250] - [4.0] Remove useless function to show all installation steps, if the entere…
- Closed
- 11 Sep 2019
- Medium
- Build: 4.0-dev
- # 26250
- Diff
- Schmidie64:joomla4_keep_flow_while_installation_process
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removed useless function in installation javascript file, which showed all installation stepts if the database credentials are incorrect.
Testing Instructions
- Start a joomla 4 installation
- In the "databse configuration"-tab enter incorrect database credentials
- Click on the "Setup Database Connection" button
- Now you should get a view, similar to the screenshot above
- Now apply my patch
- Retry the installation with incorrect database credentials
- Now you should get a view where only the "Database Configuration"-Tab is shown
Expected result
Stay on the Database Configuration"-Tab if i'am enter incorrect database-credentials.
Actual result
All installation Tabs are shown. (See screenshot above)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
wilsonge
- comment
- 11 Sep 2019
Before we check the database it seems we're revalidating other fields. Whilst you fix is clearly the behaviour we want if the db validation fails I think we may in that case need to do the database validation first in this case. Then move on to show the form and do any other required checks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-11 15:04:16 |
| Closed_By | ⇒ | wilsonge |
PR for: #25867