[#26235] - [4.0] Disable category state and access filter when indexing
- Fixed in Code Base
- 28 Oct 2019
- Medium
- Build: 4.0-dev
- # 26235
- Diff
- SharkyKZ:j4/finderCategories
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26114 and #26226.
Summary of Changes
Disables category state and access filter in finder plugins.
Testing Instructions
Enable Content - Smart Search plugin.
Create an article.
Unpublish its category.
Expected result
Category unpublished.
Actual result
An error has occurred.
0 Argument 2 passed to Joomla\Component\Finder\Administrator\Indexer\Result::addNestedTaxonomy() must implement interface Joomla\CMS\Tree\ImmutableNodeInterface, null given, called in plugins\finder\content\content.php on line 322
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
| Labels |
Added:
?
?
|
||
Why's this required now :/ this isn't an issue in 3.x right?
This isn't an issue in 3.x, since there we don't have the nested taxonomies and the taxonomy is just 2 strings. I wouldn't call this a bug.
There's definitely a bug. You can't install testing sample data without this patch
It is only a bug when I say it is a bug. The rear of the titimet is your fault :)
I have tested this item
RTC
solved #26226
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
Still holding on this for now. I believe in the end we're going to find this is related in some way to the sample data. It's good to know we have a fallback option though
Nothing to do with sample data. Finder plugins require a category. We have to disable filters here. Otherwise indexed content would differ based on who triggered the indexing.
After patching with this I do get the error stated in #26404 (comment)
Sample data or not. Only solved if I disable the smartsearch plugins.
I see we need to run category state through $this->translateState(). Not sure if we also need to check parent category state.
Should be good now, I think. @brianteeman @Quy can you test again?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
| Status | Ready to Commit | ⇒ | Pending |
Taking off RTC until we get another test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.
| Rel_Number | 0 | ⇒ | 26114 |
| Relation Type | ⇒ | Pull Request for |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-28 09:25:14 |
| Closed_By | ⇒ | HLeithner |
thx
I have tested this item✅ successfully on c114b7c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26235.