? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
9 Sep 2019

Pull Request for Issue # .

Summary of Changes

adds styling order to all stylesheets per https://developer.joomla.org/coding-standards/scss.html

Testing Instructions

reformat stylesheet

Expected result

reformats to the proper order.

Actual result

Documentation Changes Required

explain how to use .editorconfig in phpstorm and other ide's.

avatar N6REJ N6REJ - open - 9 Sep 2019
avatar N6REJ N6REJ - change - 9 Sep 2019
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Sep 2019
Title
Add all stylesheet formatting order to Editorconfig
[4.0] Add all stylesheet formatting order to Editorconfig
avatar franz-wohlkoenig franz-wohlkoenig - edited - 9 Sep 2019
avatar brianteeman
brianteeman - comment - 9 Sep 2019

aren't all the ij_ properties unique to jetbrains products?

avatar N6REJ
N6REJ - comment - 9 Sep 2019

idk.

avatar brianteeman
brianteeman - comment - 9 Sep 2019

The answer is that they are specific rules only for phpstorm

avatar N6REJ
N6REJ - comment - 9 Sep 2019

if you have a better way of doing it I"m all ears.

avatar mbabker
mbabker - comment - 9 Sep 2019

if you have a better way of doing it I"m all ears.

This is the type of thing that is probably good to add to https://github.com/joomla/coding-standards/tree/master/Joomla/IDE but for the main repo it's probably a better idea to not add things to the .editorconfig file that only apply to a single IDE from a single vendor (the intent behind .editorconfig is to be a bit more universal than "hey let's optimize the experience for PhpStorm users").

avatar N6REJ
N6REJ - comment - 9 Sep 2019

@mbabker gotcha, I thought it was ..universal?... since phpstorm had it as an export but @roland-d looked and editorconfig doesn't seem to support css/scss etc..
I'll do my best to update jdoc tomorrow. No gray matter left today.

avatar N6REJ N6REJ - change - 9 Sep 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-09-09 20:01:04
Closed_By N6REJ
Labels Added: ?
avatar N6REJ N6REJ - close - 9 Sep 2019

Add a Comment

Login with GitHub to post a comment