Feeling Lucky
?
[#26089] - Make sure passing an boolean does silently work like before in JRoute::_
- Fixed in Code Base
- 17 Sep 2019
- Medium
- Build: staging
- # 26089
- Diff
- zero-24:router_bc
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26087
Summary of Changes
Make sure passing an boolean does silently work like before cc @HLeithner #25225
Testing Instructions
echo JRoute::_('index.php', false, true)."\n"; //returns http:
echo JRoute::_('index.php', false, false)."\n"; //returns relative
echo JRoute::_('index.php', false, 1)."\n"; //return https:
echo JRoute::_('index.php', false, '1')."\n"; //returns https:
echo JRoute::_('index.php', false, JROUTE::TLS_DISABLE)."\n"; debug_zval_dump(JROUTE::TLS_DISABLE); //returns http:
echo JRoute::_('index.php', false, JROUTE::TLS_FORCE)."\n"; debug_zval_dump(JROUTE::TLS_FORCE); //returns https:
echo JRoute::_('index.php', false, JROUTE::TLS_IGNORE)."\n"; debug_zval_dump(JROUTE::TLS_IGNORE); //returns relative
Expected result
echo JRoute::_('index.php', false, true)."\n"; //returns https:
echo JRoute::_('index.php', false, -1)."\n"; //return http:
Actual result
echo JRoute::_('index.php', false, true)."\n"; //returns http:
echo JRoute::_('index.php', false, -1)."\n"; //return http:
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-17 13:02:34 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 17 Sep 2019
Thanks for fix this b/c break.
@HLeithner you need to review this as it's a 3.x regression