Feeling Lucky
NPM Resource Changed
?
?
[#26088] - [4.0] Use double colon for pseudo elements
- Fixed in Code Base
- 2 Sep 2019
- Medium
- Build: 4.0-dev
- # 26088
- Diff
- C-Lodder:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Use double colon for pseudo elements
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
brianteeman
- comment
- 30 Aug 2019
it is actually optional for this pseudo element but I am happy to blame @dgrammatiko
franz-wohlkoenig
- | Title |
|
||||||
C-Lodder
- comment
- 30 Aug 2019
@brianteeman Still optional but better to distinguish between a pseudo element and pseudo class. You also never know if browsers will drop single colons for pseudo elements in the future.
brianteeman
- comment
- 31 Aug 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26088.
Quy
- comment
- 31 Aug 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26088.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 31 Aug 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26088.
| Labels |
Added:
?
|
||
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-02 10:45:11 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 2 Sep 2019
Thanks!
ghazal
- comment
- 2 Sep 2019
I have tested this item
Just tested this on a fresh install with Composer and NPM, and I got this error in the Terminal:
The selector ".fa-dot-circle::before" was not found.
Use "@extend .fa-dot-circle::before !optional" if the extend should be able to fail.
on line 22 of build/media_source/system/scss/_icomoon.scss
>> @extend .#{$fa-css-prefix}-dot-circle::before;
compile-css could not proceed.<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/26088">issues.joomla.org/tracker/joomla-cms/26088</a>.</sub>
I should be blamed for this...