[#26085] - [4.0][com_installer] convert to prepared statement
- Fixed in Code Base
- 11 Nov 2019
- Medium
- Build: 4.0-dev
- # 26085
- Diff
- alikon:patch-121
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
use prepared statement for SQL
Testing Instructions
test com_installer
Expected result
work as before
Actual result
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-05 18:41:19 |
| Closed_By | ⇒ | alikon |
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-09-05 18:41:19 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Conflicting Files
|
||
conflict solved
| Labels |
Removed:
Conflicting Files
|
||
two fixes required and this is good to go
I have tested this item
Code reviewed this successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26085.
I have tested this item
Conde review + brief test of installing language, installing extension, updating extension, managing extension update site's download key.
Error reporting set to maximum, no errors or warning or notices in PHP log, no errors or warning in MySQL log.
Tested with MySQL 5.7
Thanks to PR #26085 for the Null Files extension for testing download key and update.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26085.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26085.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26085.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-11 23:47:46 |
| Closed_By | ⇒ | wilsonge |
Thanks!
this need a redo after #25553 merge