? ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
30 Aug 2019

Pull Request for Issue #26067

Summary of Changes

The names of presets for main menu have been changed

Testing Instructions

In Modules, open the admini module "admin menu" and change the preset.

Expected result

Everything works as before

avatar chmst chmst - open - 30 Aug 2019
avatar chmst chmst - change - 30 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2019
Category Administration com_menus Language & Strings Modules
avatar chmst chmst - change - 30 Aug 2019
The description was changed
avatar chmst chmst - edited - 30 Aug 2019
avatar chmst chmst - change - 30 Aug 2019
The description was changed
avatar chmst chmst - edited - 30 Aug 2019
avatar infograf768
infograf768 - comment - 30 Aug 2019

I guess we have to add in script the deletion of the older joomla and modern presets.
Looks like changing file names is not really understood by git which consider it is a conflict.

avatar chmst chmst - change - 30 Aug 2019
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 30 Aug 2019

I test this OK btw if the so-called conflicts can be solved.

avatar ChristineWk ChristineWk - test_item - 30 Aug 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 30 Aug 2019

I have tested this item successfully on 733d823


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

avatar infograf768 infograf768 - test_item - 30 Aug 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 30 Aug 2019

I have tested this item successfully on 733d823


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

avatar infograf768 infograf768 - change - 30 Aug 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 30 Aug 2019

RTC if conflicts can be solved

@zero-24 @HLeithner @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

avatar zero-24
zero-24 - comment - 30 Aug 2019

Yes already on my list.

avatar zero-24 zero-24 - change - 30 Aug 2019
Labels Added: ?
avatar zero-24
zero-24 - comment - 30 Aug 2019

merge conflict has been resolved

avatar infograf768
infograf768 - comment - 31 Aug 2019

Restarted drone

avatar infograf768
infograf768 - comment - 31 Aug 2019

@wilsonge @HLeithner
Please merge so that we can improve the alternate xml

avatar infograf768 infograf768 - change - 1 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-01 06:36:41
Closed_By infograf768
avatar infograf768 infograf768 - close - 1 Sep 2019
avatar infograf768 infograf768 - merge - 1 Sep 2019
avatar infograf768
infograf768 - comment - 1 Sep 2019

Thanks!

Add a Comment

Login with GitHub to post a comment