? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
28 Aug 2019

Summary of Changes

Replace Fontawesome icon to fix Batch label alignment in Actions dropdown

Testing Instructions

Go to Content > Articles
Select an article
Click Actions dropdown
Batch is misaligned

avatar Quy Quy - open - 28 Aug 2019
avatar Quy Quy - change - 28 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2019
Category Libraries
avatar infograf768 infograf768 - test_item - 28 Aug 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 28 Aug 2019

I have tested this item successfully on 964ed86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

avatar chmst chmst - test_item - 28 Aug 2019 - Tested successfully
avatar chmst
chmst - comment - 28 Aug 2019

I have tested this item successfully on 964ed86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

avatar alikon alikon - change - 28 Aug 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

avatar alikon
alikon - comment - 28 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

avatar infograf768 infograf768 - change - 28 Aug 2019
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 28 Aug 2019

The whole point of the icon-xxx class in J4 was to prevent B/C breaks for extension developers who are still using Icomoon.

icon-xxx classes in J4 are just wrappers for the fa-xxx class.

So the fact that there is misalignment with one of the icons, means there is a bug within the dropdown SCSS. The icon doesn't need changing.

avatar infograf768 infograf768 - change - 28 Aug 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 28 Aug 2019
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 28 Aug 2019

Removing RTC after @C-Lodder comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

avatar brianteeman
brianteeman - comment - 28 Aug 2019

@C-Lodder says this is not the correct fix and anyway there are other instances of the fa-square icon not addressed

avatar brianteeman
brianteeman - comment - 28 Aug 2019

see #26056

avatar Quy Quy - change - 28 Aug 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-08-28 12:46:21
Closed_By Quy
Labels Removed: ?
avatar Quy Quy - close - 28 Aug 2019

Add a Comment

Login with GitHub to post a comment