? ?
avatar mbabker
mbabker
28 Aug 2019

I'm not wasting my time checking every Bootstrap component (TBH I don't know why I'm wasting my time with the issue), but what I saw in the _badge.scss file scares me. There are lots of good ways to override things in Bootstrap; change variable values or using custom functions or mixins to add app specific logic are two good ways. Instead, the bad way of adding some CSS rules to override the SCSS generated values is used. And apparently somebody decided that badge-secondary and badge-info are the exact same thing. Why, just why!?

avatar mbabker mbabker - open - 28 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 28 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Aug 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 28 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Aug 2019
Status New Discussion
avatar infograf768
infograf768 - comment - 28 Aug 2019

@coolcat-creations
As it looks like you are the "somebody" and what you did scares "someone", can you explain?
d1b925a#diff-6a6e80a2ffae9ebe4bb49d5212880a62

avatar C-Lodder
C-Lodder - comment - 28 Aug 2019
font-size: $badge-font-size;
padding: .1rem .3rem;
border-radius:0.3rem;

These can already be set by variables.

For things like badges, I'd suggest using the background utilities rather than defining badge-danger, badge-success, etc...:

https://getbootstrap.com/docs/4.3/utilities/colors/#background-color

The badge SCSS is one example of unecessary bloat.

The same applies to the alerts. There's 6kb of MINIFIED CSS for the alerts alone, including the bootstrap ones, overrides and custom elements.

avatar dgrammatiko
dgrammatiko - comment - 28 Aug 2019

@C-Lodder for alerts specifically (same goes for tabs, tinyMCE etc...) the code is far worse. Reason: you already loading the specific CSS file (means one more http request was already done for this) and then the template overrides this files internally. The correct approach is to override the file by placing the css file in the template css directory. I guess this is very basic for anyone that did at least one website based on Joomla... In sort #FAIL

PS Charlie you remember all these talks about componentizing and modularizing the css? Well they did exactly the opposite. Forward thinking approach...

avatar mbabker
mbabker - comment - 28 Aug 2019

For things like badges, I'd suggest using the background utilities rather than defining badge-danger, badge-success, etc...:

Well until Bootstrap goes to using the background utility classes on their components, the component utility classes should still work adequately (basically, the less surprises there are between their documentation and the template implementation the better, sadly this isn't the first time I've found some awkward deviation from the Bootstrap documentation in this template).

avatar brianteeman
brianteeman - comment - 28 Aug 2019

@ALL Instead of "bitching" - roll up your sleeves

avatar dgrammatiko
dgrammatiko - comment - 28 Aug 2019

@brianteeman at least I've tried: #26014 You got to give me that...

avatar mbabker
mbabker - comment - 28 Aug 2019

Am I welcome in this repo again? Last I checked, I was on so many blacklists the blacklists had blacklists.

avatar jeckodevelopment
jeckodevelopment - comment - 29 Aug 2019

do we really have blacklists? i'm not aware of that and i should be the list keeper

avatar brianteeman
brianteeman - comment - 10 Apr 2021

Is this really still relevant. The template must have undergone at least two rewrites since then and changed to bootstrap 5

avatar alikon
alikon - comment - 10 Apr 2021

No imho

avatar alikon alikon - change - 10 Apr 2021
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2021-04-10 08:33:41
Closed_By alikon
avatar alikon alikon - close - 10 Apr 2021

Add a Comment

Login with GitHub to post a comment