? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
24 Aug 2019

Pull Request for Issue #25850

Summary of Changes

  • Remove duplicate CSS

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Same thing needs to be done for the tabs as well

avatar dgrammatiko dgrammatiko - open - 24 Aug 2019
avatar dgrammatiko dgrammatiko - change - 24 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2019
Category Administration Templates (admin)
avatar dgrammatiko dgrammatiko - change - 24 Aug 2019
Labels Added: ?
avatar dgrammatiko dgrammatiko - change - 24 Aug 2019
The description was changed
avatar dgrammatiko dgrammatiko - edited - 24 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2019
Category Administration Templates (admin) Administration Templates (admin) JavaScript Repository
avatar brianteeman
brianteeman - comment - 24 Aug 2019
Error: Undefined variable: "$atum-box-shadow".
        on line 24 of administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss
>>              box-shadow: $atum-box-shadow;
   --------------^

avatar brianteeman
brianteeman - comment - 24 Aug 2019

After making the suggested change manually I can partially confirm the fix.

The grey box is no longer displayed but the box is still there - this means that

  1. Subsequent errors are displayed below where the previous message was
  2. Any buttons that are below this now invisible box will not be selectable
avatar brianteeman
brianteeman - comment - 24 Aug 2019

The above suggests to me that your css change is just fixing a symptom and not the cause. The real problem is that closing the alert does not remove it - it just tries to hide it

avatar dgrammatiko
dgrammatiko - comment - 24 Aug 2019

The above suggests to me that your css change is just fixing a symptom and not the cause

Exactly, and it's not really a proper fix (im doing this on github's GUI...)

EDIT
NOT exactly what is happening:
Alert shows:
Screenshot 2019-08-24 at 23 10 46
On close:
Screenshot 2019-08-24 at 23 11 00
Alert completely removed.
Now if there is more styling on the container, that's obviously wrong, the container is there only for the positioning IIRC. If someone decided to apply more styles that's really wrong, but I think with this PR, once it compiles correctly the file everything should be ok

avatar brianteeman
brianteeman - comment - 24 Aug 2019

you know i dont like band aid fixes

avatar dgrammatiko
dgrammatiko - comment - 24 Aug 2019

@brianteeman this is a total clusterF37t!!
People decided to add animation and yet another container...
Screenshot 2019-08-24 at 23 17 04

FWIW alerts already have fade in animation: https://github.com/joomla-projects/custom-elements/blob/57742d291e7e906f29f82f71505dcd33e2acf5b2/src/scss/alert/alert.scss#L72

This is a rabbit hole...

avatar brianteeman
brianteeman - comment - 24 Aug 2019

(i will not comment on people only code)

avatar dgrammatiko
dgrammatiko - comment - 24 Aug 2019
avatar dgrammatiko
dgrammatiko - comment - 25 Aug 2019

@brianteeman please re open the issue, this needs a bit work that I can't do through the github GUI

avatar dgrammatiko dgrammatiko - change - 25 Aug 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-08-25 10:16:51
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 25 Aug 2019
avatar alikon
alikon - comment - 25 Aug 2019

#25850 reopened as requested

avatar HLeithner
HLeithner - comment - 25 Aug 2019

@dgrammatiko thank you very much trying to fix this. Do you plan and have time to repair it later?

avatar brianteeman
brianteeman - comment - 21 Oct 2019

@alikon looks like you didnt re-open this?

avatar dgrammatiko
dgrammatiko - comment - 21 Oct 2019

FWIW #26077 is achieving the same goal, so maybe this can be ignored

Add a Comment

Login with GitHub to post a comment