NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Aug 2019

Pull Request for Issue #25953

Summary of Changes

Thanks @Fedik
The admin-menu js was only loading the metismenu event on the first occurence of a menu.
This PR also creates different ids per menu

Steps to reproduce the issue

Create a custom admin menu with no presets (we have other issues with presets and I will create another issue for that.)
Create a menu module for that menu in the "menu" position.
Make sure the module is placed AFTER the default Admin Menu module in the Manager.

Create a Heading menu item in that custom admin menu.
Create any other menu item as child of that Heading menu item.

The result is that we have both the default Admin Menu and this custom one in the menu side bar. Below, the custom admin menu starts with Global Config.

Screen Shot 2019-08-21 at 10 31 37

Before patch

The items with arrows in the second menu do not expand

After patch

Issue solved

avatar infograf768 infograf768 - open - 23 Aug 2019
avatar infograf768 infograf768 - change - 23 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2019
Category Modules Administration JavaScript Repository NPM Change
avatar infograf768 infograf768 - change - 23 Aug 2019
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 23 Aug 2019

Need help for hound... @Fedik @wilsonge

avatar infograf768
infograf768 - comment - 23 Aug 2019

At last, hound happy.... GRRRR

avatar infograf768 infograf768 - change - 23 Aug 2019
The description was changed
avatar infograf768 infograf768 - edited - 23 Aug 2019
avatar Fedik Fedik - test_item - 23 Aug 2019 - Tested successfully
avatar Fedik
Fedik - comment - 23 Aug 2019

I have tested this item successfully on 199e916


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25995.

avatar Fedik
Fedik - comment - 23 Aug 2019

I have tested this item successfully on 199e916


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25995.

avatar richard67 richard67 - test_item - 24 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 24 Aug 2019

I have tested this item successfully on 199e916


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25995.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Aug 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Aug 2019

Status "Ready To Commit".

avatar infograf768 infograf768 - change - 26 Aug 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 27 Aug 2019

Thanks for this menu fix.

avatar HLeithner HLeithner - change - 27 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-27 11:42:43
Closed_By HLeithner
avatar HLeithner HLeithner - close - 27 Aug 2019
avatar HLeithner HLeithner - merge - 27 Aug 2019

Add a Comment

Login with GitHub to post a comment