User tests: Successful: Unsuccessful:
Pull Request for Issue #25910 (comment) by @brianteeman , thanks for catching that .
In addition, it very likely also fixes issue #25888 . Please report back when testing if it solves both or only the comment mentioned above.
Thanks to @SharkyKZ for pointing me to the right way to fix it.
This Pull Request (PR) adds the update of manifest cache for the testing sample data plugin to the installation routine for that plugin, which is function checkTestingSampledata
in file installation/src/Model/DatabaseModel.php
. It works the same way as manifest cache update of all other core extensions, which happens in function createTables
in the same file, except that a new installer class is used as suggested by @mbabker , so that there is nothing messed up with the currently used installer instance.
This fixes the PHP notices described in #25910 (comment), which happen when having the testing sample data plugin available, like is is when using the gihub repository clone and not an unzipped nightly build, and then going to the Extension Manager view.
It seems to fix also the PHP notices described in issue #25888 , which happen under the same conditions as mentioned above but on the Joomla Update Component view, but that's not 100% clear yet. There were different test results regarding that for @SharkyKZ and me.
Checkout latest 4.0-dev, do composer install
and npm install
.
Make a new clean installation into an empty database.
After successful installation, login to backend, click away the statistics dialog, go to global config, switch PHP error reporting to maximum or deveopment.
Now go to "Manage - Extensions" (or "Extensions - Manage", however is called) view. If you log PHP erros into a log file, check that log file, otherwise have display errors on so check if there is a PHP notice shown on the current page.
Result: See section "Actual result" below, item 1.
Result: See section "Actual result" below, item 2.
Result: See section "Expected result" below.
No PHP notices.
PHP Notice: Undefined property: stdClass::$version in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_installer/tmpl/manage/default.php on line 108
PHP Notice: Undefined property: stdClass::$version in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_installer/tmpl/manage/default.php on line 124
This belongs to #25910 (comment).
PHP Notice: Trying to get property 'version' of non-object in /home/richard/lamp/public_html/joomla-cms/administrator/components/com_joomlaupdate/Model/UpdateModel.php on line 1357
This belongs to issue #25888 .
No.
Status | New | ⇒ | Pending |
Category | ⇒ | Installation |
Labels |
Added:
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-18 23:23:56 |
Closed_By | ⇒ | wilsonge |
Thanks!
@SharkyKZ Testing instructions just updated. Could you test?