? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Aug 2019

Pull Request for Issue #25910 (comment) by @brianteeman , thanks for catching that .

In addition, it very likely also fixes issue #25888 . Please report back when testing if it solves both or only the comment mentioned above.

Thanks to @SharkyKZ for pointing me to the right way to fix it.

Summary of Changes

This Pull Request (PR) adds the update of manifest cache for the testing sample data plugin to the installation routine for that plugin, which is function checkTestingSampledata in file installation/src/Model/DatabaseModel.php. It works the same way as manifest cache update of all other core extensions, which happens in function createTables in the same file, except that a new installer class is used as suggested by @mbabker , so that there is nothing messed up with the currently used installer instance.

This fixes the PHP notices described in #25910 (comment), which happen when having the testing sample data plugin available, like is is when using the gihub repository clone and not an unzipped nightly build, and then going to the Extension Manager view.

It seems to fix also the PHP notices described in issue #25888 , which happen under the same conditions as mentioned above but on the Joomla Update Component view, but that's not 100% clear yet. There were different test results regarding that for @SharkyKZ and me.

Testing Instructions

  1. Checkout latest 4.0-dev, do composer install and npm install.

  2. Make a new clean installation into an empty database.

  3. After successful installation, login to backend, click away the statistics dialog, go to global config, switch PHP error reporting to maximum or deveopment.

  4. Now go to "Manage - Extensions" (or "Extensions - Manage", however is called) view. If you log PHP erros into a log file, check that log file, otherwise have display errors on so check if there is a PHP notice shown on the current page.

Result: See section "Actual result" below, item 1.

  1. Now go to the Home Dashboard and click the Joomla Update button to go to the Joomla Update view.

Result: See section "Actual result" below, item 2.

  1. Now apply the changes made by this PR, delete configuration.php and the database tables and repeat steps 2 to 5 of the above procedure.

Result: See section "Expected result" below.

Expected result

No PHP notices.

Actual result

  1. On "Manage - Extensions" view 2 PHP notices as follows:

PHP Notice: Undefined property: stdClass::$version in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_installer/tmpl/manage/default.php on line 108
PHP Notice: Undefined property: stdClass::$version in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_installer/tmpl/manage/default.php on line 124

This belongs to #25910 (comment).

  1. On Joomla Update Component view multiple PHP notices as follows:

PHP Notice: Trying to get property 'version' of non-object in /home/richard/lamp/public_html/joomla-cms/administrator/components/com_joomlaupdate/Model/UpdateModel.php on line 1357

This belongs to issue #25888 .

Documentation Changes Required

No.

avatar richard67 richard67 - open - 17 Aug 2019
avatar richard67 richard67 - change - 17 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2019
Category Installation
avatar richard67 richard67 - change - 17 Aug 2019
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2019
avatar richard67 richard67 - change - 17 Aug 2019
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2019
avatar richard67
richard67 - comment - 17 Aug 2019

@SharkyKZ Testing instructions just updated. Could you test?

avatar richard67 richard67 - change - 17 Aug 2019
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2019
avatar richard67 richard67 - change - 17 Aug 2019
Labels Added: ?
avatar SharkyKZ SharkyKZ - test_item - 17 Aug 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 17 Aug 2019

I have tested this item successfully on 0f2e2f0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25919.

avatar infograf768 infograf768 - test_item - 17 Aug 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Aug 2019

I have tested this item successfully on 0f2e2f0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25919.

avatar infograf768 infograf768 - change - 17 Aug 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 17 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25919.

avatar richard67 richard67 - change - 18 Aug 2019
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Aug 2019
avatar wilsonge wilsonge - merge - 18 Aug 2019
avatar wilsonge wilsonge - change - 18 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-18 23:23:56
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 18 Aug 2019

Thanks!

Add a Comment

Login with GitHub to post a comment