? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Aug 2019

Pull Request for new issue.

Summary of Changes

Removes duplicate element from array with core extensions in the ExtensionHelper class.

Testing Instructions

Code review: Verify that line 282 which will be removed by this PR is exactly the same as line 279, and that line 279 is correct regarding alphabetical order.

Expected result

No duplicate elements in array with core extensions in the ExtensionHelper class.

System plugins section of that array is ordered ascending in alphabetical order by column element, i.e. the 2nd one.

Actual result

Duplicate element array('plugin', 'sessiongc', 'system', 0), array with core extensions in the ExtensionHelper class in line 279 and 282 of file ExtensionHelper.php.

The one in line 279 is correct regarding alphabetical order, the other one is wrong.

Documentation Changes Required

No.

avatar richard67 richard67 - open - 17 Aug 2019
avatar richard67 richard67 - change - 17 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2019
Category Libraries
avatar richard67 richard67 - change - 17 Aug 2019
Title
Remove duplicate sessiongc from core extensions list
[4.0] Remove duplicate sessiongc from core extensions list of the ExtenshionHelper class
avatar richard67 richard67 - edited - 17 Aug 2019
avatar SharkyKZ SharkyKZ - test_item - 17 Aug 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 17 Aug 2019

I have tested this item successfully on 4958df2

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25918.

avatar infograf768 infograf768 - test_item - 17 Aug 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Aug 2019

I have tested this item successfully on 4958df2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25918.

avatar infograf768 infograf768 - change - 17 Aug 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 17 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25918.

avatar wilsonge wilsonge - close - 17 Aug 2019
avatar wilsonge wilsonge - merge - 17 Aug 2019
avatar wilsonge wilsonge - change - 17 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-17 21:29:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 17 Aug 2019

Thanks!

Add a Comment

Login with GitHub to post a comment