User tests: Successful: Unsuccessful:
When editing a menu item the display contained a large gap between content. This pull request is to provide a smaller gap. Although I also think adjusting some of the inputs from the right side to the left side might make the flow better as well.
Signed-off-by: Steven Pignataro
Labels |
Added:
?
|
Status | New | ⇒ | Pending |
Labels |
Removed:
?
|
Category | ⇒ | Templates (admin) UI/UX |
Labels |
Added:
?
|
JoomlaCode Tracker Item no longer needed:
http://developer.joomla.org/news/591-easing-the-contribution-process.html
This one's good to be tested now.
@test I tested this and the patch seems to be working:
Before: http://awesomescreenshot.com/0323oetkac
After: http://awesomescreenshot.com/07e3oetq00
Still, I personally don't like the empty space at the right-side of the page after the patch is applied.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2591.
It makes better sense having the columns next to each other vs far apart. And the bigger the screen the farther they are apart. Therefore having them closer together will make it easier to read the information and manage it.
@spignataro I understand what you are trying to do here and I can see how on a large screen if you are full screen then they are a long way away but you are changing this to have a total span of 9 (6 + 3) and I always assumed with bootstrap it had to be a total of 12 but I could be wrong
There is a problem with this PR. Since it is now using 9 columns, it doesn't behave the same way when making the screen smaller. The text overlaps for a while before the right hand part is being placed below the left part.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2591.
Labels |
Removed:
?
|
Hi @spignataro
is this issue still valid? As the last comment here was on 27 Nov 2014? Also pull requests to the master branch of this repo are not longer accepted. Can you close this pull request and submit a new one against the staging branch, if this issue still exists?
If there is no response in a month we will close the PR here.
Thanks for understanding!
The work done in layouts/joomla/edit/global.php is still valid. The other file change is not. So not sure what to do for that one. Open a new pull request?
The work done in layouts/joomla/edit/global.php is still valid.
So please close here and open a new PR aginst the staging
branche. If i correct this is only a CodeStyle change and the new PR can simple merged by a CMS Maintainer. Thanks!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-14 00:40:58 |
Thanks for your contribution! At this point in time, we are also using a separate application for issue management. Would you be so kind as to create a tracker item so that others can test and report their findings there as well.