? Success

User tests: Successful: Unsuccessful:

avatar spignataro
spignataro
25 Nov 2013

When editing a menu item the display contained a large gap between content. This pull request is to provide a smaller gap. Although I also think adjusting some of the inputs from the right side to the left side might make the flow better as well.

Signed-off-by: Steven Pignataro

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
1.00

avatar spignataro spignataro - open - 25 Nov 2013
avatar spignataro spignataro - change - 25 Nov 2013
Labels Added: ?
avatar betweenbrain
betweenbrain - comment - 27 Nov 2013

Thanks for your contribution! At this point in time, we are also using a separate application for issue management. Would you be so kind as to create a tracker item so that others can test and report their findings there as well.

avatar brianteeman brianteeman - change - 21 Aug 2014
The description was changed
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 10 Oct 2014
Category Templates (admin) UI/UX
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar nicksavov
nicksavov - comment - 16 Oct 2014

JoomlaCode Tracker Item no longer needed:
http://developer.joomla.org/news/591-easing-the-contribution-process.html

This one's good to be tested now.

avatar phuredweb phuredweb - test_item - 17 Oct 2014 - Tested successfully
avatar jespersoelundhansen jespersoelundhansen - test_item - 17 Oct 2014 - Tested successfully
avatar dimitargsg
dimitargsg - comment - 17 Oct 2014

@test I tested this and the patch seems to be working:

Before: http://awesomescreenshot.com/0323oetkac
After: http://awesomescreenshot.com/07e3oetq00

Still, I personally don't like the empty space at the right-side of the page after the patch is applied.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2591.

avatar dimitargsg dimitargsg - test_item - 17 Oct 2014 - Tested successfully
avatar spignataro
spignataro - comment - 18 Oct 2014

It makes better sense having the columns next to each other vs far apart. And the bigger the screen the farther they are apart. Therefore having them closer together will make it easier to read the information and manage it.

avatar brianteeman
brianteeman - comment - 18 Oct 2014

@spignataro I understand what you are trying to do here and I can see how on a large screen if you are full screen then they are a long way away but you are changing this to have a total span of 9 (6 + 3) and I always assumed with bootstrap it had to be a total of 12 but I could be wrong

avatar roland-d
roland-d - comment - 27 Nov 2014

There is a problem with this PR. Since it is now using 9 columns, it doesn't behave the same way when making the screen smaller. The text overlaps for a while before the right hand part is being placed below the left part.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2591.

avatar roland-d roland-d - test_item - 27 Nov 2014 - Tested unsuccessfully
avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar zero-24
zero-24 - comment - 6 Feb 2015

Hi @spignataro

is this issue still valid? As the last comment here was on 27 Nov 2014? Also pull requests to the master branch of this repo are not longer accepted. Can you close this pull request and submit a new one against the staging branch, if this issue still exists?
If there is no response in a month we will close the PR here.

Thanks for understanding!

avatar spignataro
spignataro - comment - 6 Feb 2015

The work done in layouts/joomla/edit/global.php is still valid. The other file change is not. So not sure what to do for that one. Open a new pull request?

avatar zero-24
zero-24 - comment - 6 Feb 2015

@spignataro

The work done in layouts/joomla/edit/global.php is still valid.

So please close here and open a new PR aginst the staging branche. If i correct this is only a CodeStyle change and the new PR can simple merged by a CMS Maintainer. Thanks!

avatar wilsonge wilsonge - change - 14 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 00:40:58
avatar wilsonge wilsonge - close - 14 Mar 2015

Add a Comment

Login with GitHub to post a comment