[#2590] - [#32807] add column support for extension manager->database for MSSQL
- Closed
- 6 Feb 2015
- Medium
- Build: master
- # 2590
- Diff
- sovainfo:patch-8
- Foreign ID 32807
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
See tracker [#32807] http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32807&start=0
Unfortunately JC is not reliable. So, in the unlikely event someone wants to use Extension manager->Database on MSSQL this is what this PR is about:
Extension manager->Database has very limited use but for other platforms it detects whether structural updates are applied in your environment. One of those structural changes is the ALTER TABLE <table> ADD <column>. This PR fixes the BUGS with the MSSQL implementation of that.
So, currently no differences are detected related to the columns added by updates. After applying this PR these added columns are detected when missing. And added when Fix is used!
You might also be interested in its counterpart #2615
| Title |
|
||||||
| Description | ⇒ | <p>See tracker [#32807] <a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32807&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32807&start=0</a></p> | |||||
| Labels |
Added:
?
?
|
||||||
brianteeman
- | Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | MS SQL |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Labels |
Removed:
?
|
||
| Title |
|
||||||
I applied the changes manually to staging. In Extension Manager when clicking on discover I get:
Table 'hxpmv_finder_tokens_aggregate' does not have column 'DEFAULT((0))'. (From file 3.1.0.sql.)
Table 'hxpmv_finder_tokens_aggregate' does not have column 'DEFAULT((0))'. (From file 3.1.0.sql.)
Table 'hxpmv_extensions' does not have column 'DEFAULT(N'''')'. (From file 3.1.0.sql.)
Table 'hxpmv_modules' does not have column 'DEFAULT(N'''')'. (From file 3.1.0.sql.)
Table 'hxpmv_updates' does not have column 'DEFAULT(N'''')'. (From file 3.1.0.sql.)
And when I click on Fix:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Column already has a DEFAULT bound to it.SQL=ALTER TABLE [hxpmv_extensions] ADD DEFAULT (N'') FOR [system_data];
This PR only solves detecting missing columns. Suggest to create a separate PR to deal with adding a default value to a column. It is also not suported.
Hi @sovainfo
as is this issue still valid but pull requests to the master branch of this repo are not longer accepted. Can you close this pull request and submit a new one against the staging branch?
If there is no Response in a month we will close the PR here.
Thanks for understanding!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-06 17:03:25 |
Do we have a tracker for this?