NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
16 Aug 2019

Pull Request for Issue #25873

Summary of Changes

Allow adding Read More when textarea is empty by adding in the js the case when there is no content yet, as done in 3.x.

Testing Instructions

See #25873

Before patch

We get the alert.

After patch

Read More is inserted. No more alert.

avatar infograf768 infograf768 - open - 16 Aug 2019
avatar infograf768 infograf768 - change - 16 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2019
Category JavaScript Repository NPM Change
avatar richard67 richard67 - test_item - 16 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 16 Aug 2019

I have tested this item successfully on dd61dbb

Was not easy.

Have applied patch and then run npm install and then logged out from admin, force reload of page in order not to have cached js (what normally always is sufficient), then logged in and tested and ... no change, alert still was there.

Was short before giving a negative test result, but then thought "ok, let's really CLEAR the broswer cache" ... and voilà, it worked.

It seems some of our admin js is really sticky in cache, you really have to beat it out with a sledge hammer ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25907.

avatar richard67
richard67 - comment - 16 Aug 2019

I have tested this item successfully on dd61dbb

Was not easy.

Have applied patch and then run npm install and then logged out from admin, force reload of page in order not to have cached js (what normally always is sufficient), then logged in and tested and ... no change, alert still was there.

Was short before giving a negative test result, but then thought "ok, let's really CLEAR the broswer cache" ... and voilà, it worked.

It seems some of our admin js is really sticky in cache, you really have to beat it out with a sledge hammer ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25907.

avatar infograf768 infograf768 - change - 17 Aug 2019
Labels Added: NPM Resource Changed ?
avatar richard67 richard67 - test_item - 18 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 18 Aug 2019

I have tested this item successfully on cd8099a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25907.

avatar wilsonge wilsonge - close - 18 Aug 2019
avatar wilsonge wilsonge - merge - 18 Aug 2019
avatar wilsonge wilsonge - change - 18 Aug 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-18 10:52:30
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 18 Aug 2019

Thanks!

Add a Comment

Login with GitHub to post a comment