[#25848] - Make com_joomlaupdate info and download URL opening a new page
- Fixed in Code Base
- 20 Aug 2019
- Medium
- Build: staging
- # 25848
- Diff
- zero-24:newSite
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue raised by Michael Melson on Facebook
Summary of Changes
Make sure the download URL and info URL opens as a new page.
Testing Instructions
click the update URL or the info url
Expected result
new page opens as it is a remote site
Actual result
the current page is closed and the new page is open in the same tab.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
The reason that we did not put rel="noopener noreferrer" on these links is that we are assuming that joomla.org is safe and doesn't need this security prevention.
In some cases we might use external sites like github too and IIRC it does not hurt right?
In addition if you insist on the links opening in a new window then you must add information that the link opens in a new window.
Any suggestion how? IIRC we have an css class for this? Or do you think we should do it different?
No doesnt hurt
try something like < span class = sr-only > opens in a new window </ span
try something like < span class = sr-only > opens in a new window </ span
Do we already have an example / string in core for this so we are reinventing the wheel here also does this need to go in staging as this is a PR against staging?
| Labels |
Added:
?
|
||
Please check the latest commits @brianteeman @Quy
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25848.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25848.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-20 12:52:42 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thank you for making Joomla ux better.
The reason that we did not put
rel="noopener noreferrer"on these links is that we are assuming that joomla.org is safe and doesn't need this security prevention.In addition if you insist on the links opening in a new window then you must add information that the link opens in a new window.