? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
15 Aug 2019

Pull Request for Issue raised in different forums like https://forum.joomla.de/thread/8220-joomla-version-wird-nicht-korrekt-angezeigt/?pageNo=1 about not seeing the update and even pruge updates did not help in some very also sites.

Summary of Changes

  • As of today the com_joomlaupdate purge button only checks for the update site id 1. Which is fine for new systems but it is not for older systems where might different update_site id's are used or used in parallel.
  • As of today when an update exists in the database without an extension_id we never try to assign the correct extension id later in the process.

So this PR fixes the mention problem by making sure all update sites gets checked again (we can not be sure which is joomla core) and that altleast all updates assigned to joomla core are removed from the #__updates table. We might also try truncate #__updates as the com_installer purge button does? Throughts?

Testing Instructions

  • install 3.9.10
  • go to com_joomlaupdate
  • clear the database table #__updates
  • run the following SQL (and replace the prefix #__ please):
INSERT INTO `#__updates` (`update_id`, `update_site_id`, `extension_id`, `name`, `description`, `element`, `type`, `folder`, `client_id`, `version`, `data`, `detailsurl`, `infourl`, `extra_query`) VALUES
(1, 1, 0, 'Joomla', '', 'joomla', 'file', '', 0, '3.9.11', '', 'https://update.joomla.org/core/sts/extension_sts.xml', '', ''),
(2, 11, 0, 'Joomla', '', 'joomla', 'file', '', 0, '3.9.11', '', 'https://update.joomla.org/core/sts/extension_sts.xml', '', '');

Please note that we have here an not assigned (extension_id === 0) update on update_site id 1 and 11 (as this is an older system where for some reason also a different update site id exits)

Expected result

Joomla shows the latest version as of writing 3.9.11 in com_joomlaupdate

Actual result

Joomla claims that 3.9.10 in the current version even when we hit the pruge button.

Documentation Changes Required

none.

avatar zero-24 zero-24 - open - 15 Aug 2019
avatar zero-24 zero-24 - change - 15 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2019
Category Administration com_joomlaupdate Libraries
avatar zero-24 zero-24 - change - 16 Aug 2019
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Aug 2019
Title
[com_joomlaupdate] Make sure the pruge updates button works reliability
[com_joomlaupdate] Make sure the purge updates button works reliability
avatar zero-24 zero-24 - edited - 17 Aug 2019
avatar zero-24 zero-24 - change - 17 Aug 2019
The description was changed
avatar zero-24 zero-24 - edited - 17 Aug 2019
avatar richard67 richard67 - test_item - 18 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 18 Aug 2019

I have tested this item successfully on 6cc3b0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25847.

avatar zero-24
zero-24 - comment - 18 Aug 2019

Thanks @richard67 !

avatar viocassel viocassel - test_item - 18 Aug 2019 - Tested successfully
avatar viocassel
viocassel - comment - 18 Aug 2019

I have tested this item successfully on 6cc3b0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25847.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Aug 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2019

Status "Ready To Commit".

avatar HLeithner
HLeithner - comment - 19 Aug 2019

Thanks for being a true mr. Proper.

avatar HLeithner HLeithner - close - 19 Aug 2019
avatar HLeithner HLeithner - merge - 19 Aug 2019
avatar HLeithner HLeithner - change - 19 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-19 09:58:41
Closed_By HLeithner
Labels Added: ?

Add a Comment

Login with GitHub to post a comment