[#25813] - [4.0] Remaining install sample data screen
- Closed
- 13 Aug 2019
- Medium
- Build: staging
- # 25813
Steps to reproduce the issue
Install a clean build.
Install or not some languages, then skip
Expected result
If there is some sample data to install, get the details and install.
If none is available, then go back to complete installation.
Actual result
As there is no more sample data to install we get a screen like below where the ini lang strings do not exist anymore as they have been recently deleted.
Code concerned is in
/installation/tmpl/remove/default.php
and
/installation/src/Form/Field/Installation/SampleField.php
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Discussion |
As part of #25692 we auto-install custom.sql if it exists.
https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Model/DatabaseModel.php#L713-L722
Basically I'm taking the opinion that as most template providers already offer downloads of file or sample data the 90% use case is the users downloaded it to install sample data. If the template dev's want more flexibility than that then they'll have to go down the plugin approach.
TL/DR It's fine to just remove the step.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-13 06:16:33 |
| Closed_By | ⇒ | franz-wohlkoenig |
Related #20262