? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Aug 2019

Pull Request for Issue #25694 .

Summary of Changes

suppress logout log message when user blocked by anadmin
when a user is blocked from an admin the logout is forced for tecnical reason, so the user itself not have performed the logout action

Testing Instructions

block an user

Expected result

the message logged is only about the "update" action by the admin
Screenshot from 2019-08-11 10-31-35

Actual result

the logged message says that the user is logged out

avatar alikon alikon - open - 11 Aug 2019
avatar alikon alikon - change - 11 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2019
Category Front End Plugins
avatar richard67
richard67 - comment - 11 Aug 2019

@alikon What happens if the user is really logged in? Will he/she then be logged out? I think this should be the case.

avatar richard67
richard67 - comment - 11 Aug 2019

I have tested this item successfully on 8d6b263

Without this PR, the user actions log tells that the user was logged out, but this is not really the case. The user is still logged in and can refresh the admin page, and for both, the first user is still shown as being logged in on the logged in users module.

With this PR, the user actions log does not tell this lie anymore that the user has been logged out. The rest of the described behavior remains the same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

avatar richard67 richard67 - test_item - 11 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 11 Aug 2019

@shraddhaSankpal27 Could you test if this pull request (PR) here corrects your issue #25694 ?
Just apply the changes of this PR and test. After test, please mark your test result on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/25812 by using the "Test this" button at the top left corner of that page, then selecting the test result and then submitting.

avatar Quy
Quy - comment - 12 Aug 2019

I have tested this item successfully on 8d6b263


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

avatar Quy Quy - test_item - 12 Aug 2019 - Tested successfully
avatar Quy Quy - change - 12 Aug 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

avatar shraddhaSankpal27
shraddhaSankpal27 - comment - 13 Aug 2019

I have tested this item successfully on 8d6b263

avatar shraddhaSankpal27
shraddhaSankpal27 - comment - 13 Aug 2019

I have tested this item successfully on 8d6b263


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25812.

avatar shraddhaSankpal27 shraddhaSankpal27 - test_item - 13 Aug 2019 - Tested successfully
avatar HLeithner
HLeithner - comment - 23 Aug 2019

Thank you making the action log a bit more correct.

avatar HLeithner HLeithner - change - 23 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-23 14:12:15
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 23 Aug 2019
avatar HLeithner HLeithner - merge - 23 Aug 2019

Add a Comment

Login with GitHub to post a comment