Feeling Lucky
NPM Resource Changed
?
[#25779] - [4.0] joomla-field-module-order a11y
- Fixed in Code Base
- 5 Aug 2019
- Medium
- Build: 4.0-dev
- # 25779
- Diff
- brianteeman:sun2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23888 .
Summary of Changes
The id the label was for was the parent <joomla-field-module-order
it should have been on the select
To avoid having a duplicate id I changed it to data-id on the <joomla-field-module-order
so that the correct ID is on the select
Testing Instructions
You will need to run npm i to rebuild the js
Go to Modules new/edit
Use screen reader (I use NVDA), move focus to Ordering field
or
Click on the Ordering label
Expected result
screen reader should announce the role combobox and the label Ordering
or
you click on a label, the field should receive a focus
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Layout |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-05 16:14:19 |
| Closed_By | ⇒ | wilsonge |
brianteeman
- comment
- 5 Aug 2019
Thanks
Thanks!