Feeling Lucky
?
?
[#25773] - [4.0] Sample data fix - Tags ids need to be sent as a string to the helper
- Fixed in Code Base
- 4 Aug 2019
- Medium
- Build: 4.0-dev
- # 25773
- Diff
- wilsonge:fix/testing-data-tags
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Tags need to be submitted as a string to the model rather than as an integer. So simply mapping them to a string here. To test install sample data. Before patch there are integers in the main homepage article tags. After patch they are the expected colours from Joomla 3.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
richard67
- comment
- 4 Aug 2019
I have tested this item
Tested with MySQL 5.7 and PostgreSQL 10.9.
@wilsonge I gave it a good test because it works, but I would prefer if you would also apply my suggested change for using array_slice($tagIds, 0, 3) instead of array($tagIds[0], $tagIds[1], $tagIds[2]).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25773.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 4 Aug 2019
Status "Ready To Commit".
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-04 10:33:01 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 4 Aug 2019
Thanks guys!
richard67
- comment
- 4 Aug 2019
Thanks George!!!
I have tested this item✅ successfully on 18d654a
tested on postgresql 11.4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25773.