J4 Issue ?
avatar Scrabble96
Scrabble96
3 Aug 2019

Is your feature request related to a problem? Please describe.

Looking at an installation of 03 Aug 2019 nightly build Joomla_4.0.0-alpha11-dev-Development-Full_Package

In the admin editor (Codemirror) when editing index.php, for example, there are several editor buttons that run onto a second row. It looks rather messy, with the two rows touching each each other and a gap at the beginning of the second row:

buttons-jammed-together

Describe the solution you'd like

Tidy up the CSS. I have no idea where this code comes from, but using the Firefox inspector I can recommend the following changes end up in template.min.css and/or the html code:

Where the html is
<div id="subhead" class="subhead">
change the associated CSS from
.subhead { padding: 13px 0; }
to
.subhead { padding: 13px 0 5px 0; }

Then, where applicable to html code like this:
<button class="btn btn-primary" data-toggle="modal" data-target="[various options]">
change CSS from
.subhead .btn-toolbar > * { margin-left: .75rem; }
to:
.subhead .btn-toolbar > * { margin-right: .75rem; margin-bottom: .5rem; /* new code added */ }

After this, there is no longer any need for the first-child left margin CSS:
.subhead .btn-toolbar > :first-child { margin-left: 0; }

and,
EITHER add a new class to right-align the help button:
#toolbar-help { margin-right: 0; }
OR, change the html:
<joomla-toolbar-button id="toolbar-help" class="ml-auto"> to
<joomla-toolbar-button id="toolbar-help" class="ml-auto mr-0">

It will now all look like this:

buttons-tidied

Additional context

This could possibly apply to other areas of the Admin panel.

avatar Scrabble96 Scrabble96 - open - 3 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Aug 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 3 Aug 2019
avatar brianteeman
brianteeman - comment - 3 Aug 2019

Its nothing to do with codemirror.

avatar Quy
Quy - comment - 3 Aug 2019

Please test the new backend template PR #25570. There is a link to the nightly build in the PR.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Aug 2019
Status New Discussion
avatar Quy
Quy - comment - 3 Aug 2019

Duplicate PR #24579. Here is the new backend template.

25772

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Aug 2019

closed as stated above.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Aug 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-08-04 04:05:12
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 4 Aug 2019
avatar Scrabble96
Scrabble96 - comment - 4 Aug 2019

I have just installed the 'new' backend template as per PR #25570

The button layout is fine when you first click into the template files system:

files

BUT, as soon as you select a file to edit, there is almost the same layout I mentioned earlier, except that the Help button is correctly right-aligned:

new-dev-layout

avatar brianteeman
brianteeman - comment - 4 Aug 2019

We could group all the file/folder actions into a single dropdown button

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Aug 2019
Status Closed New
Closed_Date 2019-08-04 04:05:12
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - reopen - 4 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Aug 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 16 Sep 2019

Can the title of this be changed to com_templates from codemirror pplease

avatar Quy Quy - change - 16 Sep 2019
Title
[4.0] Tidy up the codemirror editor button layout
[4.0] Tidy up the com_templates button layout
avatar Quy Quy - edited - 16 Sep 2019
avatar Quy Quy - change - 5 Jun 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-06-05 18:52:58
Closed_By Quy
avatar Quy
Quy - comment - 5 Jun 2020

Please test PR #29446

avatar Quy Quy - close - 5 Jun 2020

Add a Comment

Login with GitHub to post a comment