? Error

User tests: Successful: Unsuccessful:

avatar bluefractals
bluefractals
21 Nov 2013

Added params such as module_tag and module_class...

avatar tisola tisola - open - 21 Nov 2013
avatar tisola tisola - change - 22 Nov 2013
Status New Closed
Closed_Date 0000-00-00 00:00:00 2013-11-22 13:32:44
Labels Added: ?
avatar tisola tisola - close - 22 Nov 2013
avatar tisola tisola - change - 22 Nov 2013
Status Closed New
avatar tisola tisola - reopen - 22 Nov 2013
avatar Bakual
Bakual - comment - 22 Nov 2013

@tisola Can you open a corresponding tracker item in the feature tracker (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549) and link back here?

Also have a look at how this is done in the html5 chrome and use the same approach. This will also fix the issue @beat mentioned with the missing class = "...".

And if you're at it, wouldn't it make sense to add those parameters to other chromes there as well (where appropriate)?

avatar tisola
tisola - comment - 22 Nov 2013

Why is it failing the test? Like @mbabker stated, is Travis failure unrelated in this case?

avatar Bakual
Bakual - comment - 22 Nov 2013

@tisola Looks unrelated to this change as I have the same error in a completely different PR. It's somehow related to some registry stuff where <node name="booleanfalse" type="boolean"></node> is expected but <node name="booleanfalse" type="boolean"/> returned.

avatar mbabker
mbabker - comment - 22 Nov 2013

It's something in JRegistry which is behaving differently depending on the
environment configuration. Unrelated to this.

On Friday, November 22, 2013, Thomas Hunziker wrote:

@tisola https://github.com/tisola Looks unrelated to this change as I
have the same error in a completely different PR. It's somehow related to
some registry stuff where is expected but name="booleanfalse" type="boolean"/> returned.


Reply to this email directly or view it on GitHub#2572 (comment)
.

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 1 Sep 2014
Category Modules
avatar zero-24
zero-24 - comment - 6 Feb 2015

Hi @tisola

is this issue still valid? As the last comment here was on 22 Nov 2013? Also pull requests to the master branch of this repo are not longer accepted. Can you close this pull request and submit a new one against the staging branch, if this issue still exists?
If there is no Response in a month we will close the PR here.

Thanks for understanding!

avatar vdespa vdespa - change - 14 Mar 2015
Status Pending Closed
Closed_Date 2013-11-22 13:32:44 2015-03-14 13:29:29
Closed_By vdespa
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2015
Closed_Date 2015-03-14 13:29:29 2015-03-14 13:29:30
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Mar 2015

Set to "closed" on behalf of @vdespa by The JTracker Application at issues.joomla.org/joomla-cms/2572

avatar joomla-cms-bot joomla-cms-bot - close - 14 Mar 2015

Add a Comment

Login with GitHub to post a comment