? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
27 Jul 2019

Pull Request for Issue #25592 cc @brianteeman

Summary of Changes

rename the option to Force HTTP Headers and clearly state in the description what is happening here.

Testing Instructions

Please note the new description of the option.

Expected result

Force HTTP Headers

Actual result

Additional HTTP Headers

Documentation Changes Required

This is not documented yet but it should be ;)

avatar zero-24 zero-24 - open - 27 Jul 2019
avatar zero-24 zero-24 - change - 27 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2019
Category Administration Language & Strings
avatar zero-24 zero-24 - change - 27 Jul 2019
Labels Added: ? ? ?
avatar brianteeman
brianteeman - comment - 27 Jul 2019

It's still problematic
If you set "write headers to configuration file" and then options as in this screenshot
image

Then both referrer policy are written to the htaccess file
image

Although only the second one will be used.

avatar brianteeman
brianteeman - comment - 27 Jul 2019

actually its a little more complicated than I wrote above. As sometimes you do only get the one line.

Its all very confusing. Writing headers to the file actually makes it more confusing (for me). Is it even compatible with setting headers for site or admin or both?

There is no way to delete all the headers from the htaccess. So once they have been written to the htaccess if you then disable that option no changes made to the settings will be applied

We also now have the situation that we have rules set in the htaccess, rules set in the plugin, and rules set in the component and no way to see in one place all the rules that are being applied. This will make debugging a faulty rule very hard.

avatar zero-24
zero-24 - comment - 27 Jul 2019

Can we please open a separate issue for the htaccess issue, so we can keep this here to the suggested rename of the feature?

avatar zero-24
zero-24 - comment - 27 Jul 2019

Although only the second one will be used.

Isn't that what force implies?

avatar zero-24
zero-24 - comment - 27 Jul 2019

Can we please open a separate issue for the htaccess issue, so we can keep this here to the suggested rename of the feature?

Done here: #25716 so we can keep this on renaming the feature as suggested.

avatar Quy
Quy - comment - 5 Aug 2019

I have tested this item successfully on dd28fac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25713.

avatar Quy
Quy - comment - 5 Aug 2019

I have tested this item successfully on dd28fac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25713.

avatar Quy Quy - test_item - 5 Aug 2019 - Tested successfully
avatar wilsonge wilsonge - change - 13 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-13 12:11:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Sep 2019
avatar wilsonge wilsonge - merge - 13 Sep 2019
avatar wilsonge
wilsonge - comment - 13 Sep 2019

This makes sense and combined with the apache file no longer being edited I believe this solves the other part of the issue. Thanks!

avatar zero-24
zero-24 - comment - 28 Sep 2019

Doc change Done.

Add a Comment

Login with GitHub to post a comment