? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
27 Jul 2019

Pull Request for Issue #25594 cc @brianteeman

Summary of Changes

show a warning in case we are collecting but there are trashed itms

Testing Instructions

  • Enable the collecting mode of com_csp
  • collect some reports
  • trash a few or all of them
  • refresh the reports list

Expected result

You should now get a warning indicating that we are collecting but have also trashed items

Actual result

No indication that we have trashed items.

Documentation Changes Required

none.

Additional Info

@brianteeman I'm not happy with the warning message yet, you might can suggest a bettwer wording here? Thanks.

avatar zero-24 zero-24 - open - 27 Jul 2019
avatar zero-24 zero-24 - change - 27 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2019
Category Administration com_csp Language & Strings
avatar zero-24 zero-24 - change - 27 Jul 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 27 Jul 2019

I have tested this item successfully on 024acda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25712.

avatar brianteeman brianteeman - test_item - 27 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 28 Jul 2019

I have tested this item successfully on 024acda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25712.

avatar richard67 richard67 - test_item - 28 Jul 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - close - 1 Aug 2019
avatar wilsonge wilsonge - merge - 1 Aug 2019
avatar wilsonge wilsonge - change - 1 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-01 15:15:36
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 1 Aug 2019

Thanks!

Add a Comment

Login with GitHub to post a comment