Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25705] - [Protostar] Possibly redundant code

J3 Issue ?
avatar ciar4n
ciar4n
25 Jul 2019

Pretty sure this statement is redundant.... https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/index.php#L31-L38

  1. I can't find $fullWidth been used anywhere
  2. I cant get $task === 'edit'

Also... https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/offline.php#L20
And... https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/error.php#L29-L36

avatar ciar4n ciar4n - open - 25 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Jul 2019
avatar ciar4n ciar4n - change - 25 Jul 2019
Title
…
[Protostar] Possibly redunant code
[Protostar] Possibly redundant code
avatar ciar4n ciar4n - edited - 25 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Jul 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 25 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Jul 2019
Status New ⇒ Discussion
avatar brianteeman
brianteeman - comment - 25 Jul 2019

if i remember correctly this was used to make the edit pages full width and not cramped by left and right modules. it was set with mootools iirc

avatar Quy
Quy - comment - 18 Sep 2019

The code added here, however, no context provided to determine its purpose. OK to remove?

avatar SharkyKZ
SharkyKZ - comment - 18 Sep 2019

Yes, it's unused.

avatar Quy Quy - close - 19 Sep 2019
avatar Quy Quy - change - 19 Sep 2019
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-09-19 16:05:45
Closed_By ⇒ Quy
avatar Quy
Quy - comment - 19 Sep 2019

Please test PR #26361.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25705.

Add a Comment

Login with GitHub to post a comment