[#25600] - [4.0] Improving phpcs setup
- Fixed in Code Base
- 24 Jul 2019
- Medium
- Build: 4.0-dev
- # 25600
- Diff
- Hackwar:j4phpcscomposer
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This PR simplifies the call to phpcs and automatically sets the installed_paths of phpcs with composer. This depends on joomla/cms-coding-standard to push the latest release to packagist. It also fixes a codestyle violation.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests External Library Composer Change Libraries |
| Labels |
Added:
?
?
?
|
||
| Category | Unit Tests External Library Composer Change Libraries | ⇒ | Unit Tests External Library Composer Change |
The parameter in cms-coding-standard does not have an effect and the paths are not set per terminal session, but are set once in a config file of phpcs. We had a whole additional package in our composer.json which practically only did what the script now does. So this is required here and needs to be removed from the cms-coding-standard. PR for that is coming soon.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-24 19:00:55 |
| Closed_By | ⇒ | wilsonge |
Thanks!
The build fails:
phpcs --config-set installed_paths ../../joomla/cms-coding-standards/lib,../../joomla/coding-standards
sh: 1: phpcs: not found
Script phpcs --config-set installed_paths ../../joomla/cms-coding-standards/lib,../../joomla/coding-standards handling the post-install-cmd event returned with error code 127
composer installdid not complete as expected.
Thanks !
This either isn’t required here or is required as a consequence of https://github.com/joomla/cms-coding-standards/blob/4.0-dev/lib/Joomla-CMS/ruleset.xml#L11 or can be removed. In addition this should be called per running of the tests. Because in real life people can have multiple terminal sessions running not running composer install to facilitate that