? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Jul 2019

Someone merged broken codestyle code into 4.0-dev. This fixes that. Do not merge until at least phpcs has passed properly.

avatar Hackwar Hackwar - open - 16 Jul 2019
avatar Hackwar Hackwar - change - 16 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2019
Category Administration com_banners
avatar brianteeman
brianteeman - comment - 16 Jul 2019

Then there is a problem with the code checker as that wasnt picked up
https://ci.joomla.org/joomla/joomla-cms/21055/1/8

avatar Hackwar
Hackwar - comment - 16 Jul 2019

It is throwing errors and it showed those on the last commit to that PR. I don't see an issue with our CI system there.

avatar brianteeman
brianteeman - comment - 16 Jul 2019

My apologies - I misread the change here

avatar HLeithner HLeithner - change - 16 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-16 22:17:37
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 16 Jul 2019
avatar HLeithner HLeithner - merge - 16 Jul 2019
avatar HLeithner
HLeithner - comment - 16 Jul 2019

Thx

Add a Comment

Login with GitHub to post a comment