[#25596] - [4.0] Adding sass-lint for SCSS codestyle checks
- Closed
- 17 Jul 2019
- Medium
- Build: 4.0-dev
- # 25596
- Diff
- Hackwar:j4scsslint
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This adds a linter for our SCSS files and enforces a bunch of rules, which I found reasonable. There is no deeper reason for the set of rules that I selected other than that I like them. That also means that this ruleset is completely up for debate.
This uses sass-lint, which can be found here: https://github.com/sasstools/sass-lint
The list of available rules can be found here: https://github.com/sasstools/sass-lint/tree/master/docs/rules
For now the step is set to be ignored upon failure, so that we have a chance to fix these codestyle violations one by one.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests NPM Change |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-17 08:10:33 |
| Closed_By | ⇒ | wilsonge |
Closing as Michael is absolutely right here
Ok, I wasn't sure if that even worked. Looking at the configuration, there are a few issues there... I'll bring this up in the ATT and we'll discuss it there.
There's already a SCSS ruleset defined. Look at the Hound CI integration, whose sole purpose is to lint the SCSS and JS files.