Feeling Lucky
NPM Resource Changed
?
[#25572] - [4.0] remove unused js files
- Fixed in Code Base
- 16 Jul 2019
- Medium
- Build: 4.0-dev
- # 25572
- Diff
- brianteeman:mon6
- Success Hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
pr for #25568
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
brianteeman
- comment
- 16 Jul 2019
@richard67 while J4 is in alpha we're not doing that per PR. @wilsonge is doing it with a script
richard67
- comment
- 16 Jul 2019
@brianteeman Thanks. I know he has a script. I only did not know when he will use it, so I thought I leave a reminder. I did not expect it do be done with this PR here, that's why I gave it a good test.
| Labels |
Added:
NPM Resource Changed
?
|
||
wilsonge
- comment
- 16 Jul 2019
Thanks!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-16 19:29:06 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 868240e
Code review: This PR removes only the files mentioned in issue #25568 , not more and not less. It seems that these files are really not used anymore, but I can't grant this for 100%, I might have overseen something.
Hint: After these files have been removed with this PR, someone should add them to admin.php for removal, e.g. if the script for creating the list of removed files and folders is run.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25572.