? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Jul 2019

second attempt at a PR to remove the unused xreference field

the one thing I dont know what to do is how to handke sites upgrading from 3 to 4

avatar brianteeman brianteeman - open - 13 Jul 2019
avatar brianteeman brianteeman - change - 13 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2019
Category Administration com_contact com_content com_newsfeeds Language & Strings Front End SQL Installation Postgresql Layout Libraries Plugins
avatar Quy
Quy - comment - 14 Jul 2019

Here is a discussion on External Reference.
Here is the output <meta name="xreference" content="http://www.domain.com"> for this field.

avatar brianteeman
brianteeman - comment - 14 Jul 2019

xreference is not part of the official specification https://html.spec.whatwg.org/multipage/semantics.html#standard-metadata-names

xreference is not even part of the metaextensions
https://wiki.whatwg.org/wiki/MetaExtensions

avatar mbabker
mbabker - comment - 14 Jul 2019

the one thing I dont know what to do is how to handke sites upgrading from 3 to 4

Drop the columns and indexes using an update SQL file, leave the metadata alone (no point in trying to manipulate JSON params fields to remove unused data, look at the 3.9.7 and 3.9.8 follow-on release as an example of why this isn't really necessary in the first place or why it's not the most reliable thing without proper JSON SQL support).

avatar brianteeman
brianteeman - comment - 14 Jul 2019

thanks @mbabker
I was never thinking of touching the json data
It was more a what if someone had some data in those columns - do we care?

avatar mbabker
mbabker - comment - 14 Jul 2019

No? Otherwise, PHPCS needs to blacklist every remove column/index/table statement from being part of the update SQL files in case someone has data in those areas as someone might be using it (either for intended purpose or repurposing for some unrelated thing).

avatar brianteeman brianteeman - change - 14 Jul 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2019
Category Administration com_contact com_content com_newsfeeds Language & Strings Front End SQL Installation Postgresql Layout Libraries Plugins SQL Administration com_admin Postgresql com_contact com_content com_newsfeeds Language & Strings Front End Installation Layout Libraries Plugins
avatar brianteeman
brianteeman - comment - 14 Jul 2019

queries done

avatar wilsonge wilsonge - change - 26 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-26 12:54:19
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Jul 2019
avatar wilsonge wilsonge - merge - 26 Jul 2019
avatar wilsonge
wilsonge - comment - 26 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 26 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment