[#25548] - [4.0] Updating to PHPCS3
- Fixed in Code Base
- 19 Jul 2019
- Medium
- Build: 4.0-dev
- # 25548
- Diff
- Hackwar:j4codestyle
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This updates PHPCS to version 3 and fixes all violations. This requires joomla/cms-coding-standards#5 to be merged.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Administration com_languages External Library Composer Change Libraries |
As I wrote above, the other PR to cms-coding-standards has to be merged first for this to work.
Tagged an alpha2 so please use that rather than just dev
| Labels |
Added:
?
?
?
|
||
I have no idea what I have to put into the composer.json for that. Also, the tag says that there are 0 commits in that tag. Otherwise this would be ready for now.
Now the alpha has been released please use the tagged version rather than the branch
We seems to have significantly less assertions in PHPCS 3 than 2. Is there a reason for this?
v2 runs deprecated code filters also there where some exclude filter issues, now on v3 it has been resolved.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-19 15:26:19 |
| Closed_By | ⇒ | rdeutz |
I guess it goes without saying drone doesn't think this works :) Maybe the cache?