What about those migrating from 3.x to 4.0? Doesn't the com_mailto directory need removing too?

I "think" the pr does that. For the migrating users then it will be handled by script.php at update time

will be handled by script.php at update time

but the required changes to that file are missing in the script.php right now?

I have also added the Documentation required label as this should be included in the docs too :)

but the required changes to that file are missing in the script.php right now?

I meant that the script.php will be updated near to release time in one go. If you noticed you would see that there have not been any commits to that file during the development of J4 with individual PR

I have also added the Documentation required label as this should be included in the docs too :)

What documentation

https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4

Maybe an dedicated page why or better that we removed it makes sense too.

its not a bc issue

better to spend your time making security headers actually work

better to spend your time making security headers actually work

I'm sorry is there a reason to personally attact me? Can you please tell me what is the problem at the security headers? As there are already bigger changes planed when the current PR gets merged, I can check on the issues too.

it doesnt work at all.

it doesnt work at all.

hmm please share your configuration and the steps to reproduce with me. I have just tried it on php 7.3 with the latest build and it worked correctly, but I'm happy to debug and improve what ever is needed. Thanks :)

see #25592 had to guess what to do as I couldnt find any documentation

@brianteeman please can you provide testing instructions and i will test this PR so it can be accepted. I assume I can simply apply this patch then search in "manage extensions" for "mail to" and if it does not exist I can pass this PR?

Do we need to install sample data? I get this error:

The file marked for modification does not exist: installation/sql/mysql/sample_testing.sql

When trying to install the "testing" sample data I also get another error. I know that's unrelated but can you confirm it makes this test impossible. Or is the sample_testing.sql part of this pull request unecessary?

conflicts resolved.

@uglyeoin that will resolve your patchtester error. As for testing instructions you got it right

God almighty. Who do I have to butter up to get that tooltip off the issue number in Patchtester when I try to type it in? It's destroying my brain.

I cannot apply the patch.

The patch could not be applied because it conflicts with a previously applied patch: installation/sql/mysql/joomla.sql

I have checked and this is the only patch applied, I have reverted all others.

God almighty. Who do I have to butter up to get that tooltip off the issue number in Patchtester when I try to type it in? It's destroying my brain.

Are you referring to the alert? Try this: #25850 (comment)

@uglyeoin report that to the patchtester repo. I cannot confirm with the old version of patchtester I use.

@Quy that isn't the problem, this is the problem. joomla-extensions/patchtester#243 (comment)

I suggested the solution. I'd do a pull request but I'm really not sure how to do it when it comes to compiled CSS. If someone can point me at instructions I'll give it a go.

conflicts resolved

I have tested this item ✅ successfully on 3f180e9

Is there any point in me resolving conflicts again or am I wasting my time

conflicts resolved and deprecation pr created

Deprecation PR merged ?

Thanks for removing this awful feature.

Finally!!!!