? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Jul 2019

The check of isset is wrong and it should be !empty

If you have an outdated extension then it will display a non clickable url to the xml AND if set a clickable url to a details page

The existing code would still output a br and and empty a if there was no details page available. This simple PR fixes that

avatar brianteeman brianteeman - open - 10 Jul 2019
avatar brianteeman brianteeman - change - 10 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2019
Category Administration com_installer
avatar brianteeman brianteeman - change - 10 Jul 2019
Labels Added: ?
avatar Quy
Quy - comment - 10 Jul 2019

I have tested this item successfully on 36bde05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25494.

avatar Quy Quy - test_item - 10 Jul 2019 - Tested successfully
avatar tonypartridge tonypartridge - test_item - 13 Jul 2019 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

I have tested this item successfully on acf95b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25494.

avatar Quy Quy - change - 13 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25494.

avatar wilsonge wilsonge - change - 13 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-13 19:02:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 Jul 2019
avatar wilsonge wilsonge - merge - 13 Jul 2019
avatar wilsonge
wilsonge - comment - 13 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 13 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment