[#25493] - [4.0] Stop TinyMCE autochanging skins when new skins are uploaded
- Fixed in Code Base
- 16 Feb 2020
- Medium
- Build: 4.0-dev
- # 25493
- Diff
- SharkyKZ:j4/tinymceSkins
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Redo of #22097 .
Summary of Changes
Currently, we store TinyMCE skin setting as a numeric value provided by glob(). This can cause the skin to automatically change when uploading a new skin.
This removes custom JFormFieldSkins field and replaces it with standard folder list field in form.
Testing Instructions
Edit TinyMCE plugin. In your set (Set 0 by default) select a skin. Save the plugin.
Upload a skin with name that alphabetically orders before your selected skin.
Edit an article.
You should see the new skin being used or the editor not appearing at all.
Remove the custom skin.
Apply patch.
Save plugin configuration again.
Upload the skin again.
Edit an article.
Now your selected skin should be used.
Documentation Changes Required
JFormFieldSkins is removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
This does indeed fail to stop the plugin change and to stop the editor breaking
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25493.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25493.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25493.
@flyingwombats @jaydevingawale Please retest this.
Should we also set default values in the XML (given we already have them in the PHP?). Other than that LGTM
I intentionally left this part the way it was.
I guess we could add the - Use Default - option with empty value. This way, if selected theme is deleted, the field will use empty value rather than the first option alphabetically. And we'll fall back to oxide in the code.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-16 21:47:19 |
| Closed_By | ⇒ | wilsonge |
LGTM!
I have tested this item? unsuccessfully on 16dea33
It still shows the blank page
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25493.