? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
6 Jul 2019

We have a long-tested codestyle for the CMS which we hesitated so far to adopt. The new codestyle is a lot stricter and this results in several errors.

To finally adopt this new codestyle, #25447 sets up our CI system to run both the old and the new codestyle in parallel. This PR is the second PR in a series to patch the codestyle 20 files at a time. There should be 319 files with issues. All PRs will be based on each other to finally have a passing PR. I guess the best solution would be to wait until I'm done and then go through these PRs starting with #25447 and merge them one by one. The prior PR is #25450

avatar Hackwar Hackwar - open - 6 Jul 2019
avatar Hackwar Hackwar - change - 6 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2019
Category Unit Tests Administration com_admin com_associations com_banners com_categories com_config com_contact com_content
avatar Hackwar Hackwar - change - 6 Jul 2019
Title
J4test codestyle fixes2
[4.0] Codestyle fixes for new CMS codestyle Batch 2/16?
avatar Hackwar Hackwar - edited - 6 Jul 2019
avatar Hackwar Hackwar - change - 11 Jul 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2019
Category Unit Tests Administration com_admin com_associations com_banners com_categories com_config com_contact com_content Administration com_associations com_contact com_content com_cpanel com_fields com_finder Modules External Library Composer Change
avatar Hackwar Hackwar - change - 11 Jul 2019
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2019
Category Administration com_associations com_contact com_content com_cpanel com_fields com_finder Modules External Library Composer Change Administration com_contact com_content com_cpanel com_fields com_finder Modules External Library Composer Change
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2019
Category Administration com_contact com_content com_cpanel com_fields com_finder Modules External Library Composer Change Administration com_contact com_content com_cpanel com_fields com_finder External Library Composer Change
avatar wilsonge wilsonge - change - 11 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-11 20:20:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Jul 2019
avatar wilsonge wilsonge - merge - 11 Jul 2019
avatar wilsonge
wilsonge - comment - 11 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment