? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
6 Jul 2019

We have a long-tested codestyle for the CMS which we hesitated so far to adopt. The new codestyle is a lot stricter and this results in several errors.

To finally adopt this new codestyle, #25447 sets up our CI system to run both the old and the new codestyle in parallel. This PR is the start of a series to patch the codestyle 20 files at a time. There should be 319 files with issues. All PRs will be based on each other to finally have a passing PR. I guess the best solution would be to wait until I'm done and then go through these PRs starting with #25447 and merge them one by one.

ATTENTION!!

Almost all fixes to the codestyle for the new style have been done in the linked PRs below. The last one is #25471 and after this PR, there are still errors present, which seem to be related to issues in the sniffs. Please check those first and find solutions to this BEFORE merging all these PRs!

avatar Hackwar Hackwar - open - 6 Jul 2019
avatar Hackwar Hackwar - change - 6 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2019
Category Unit Tests Administration com_admin com_associations com_banners com_categories com_config com_contact Modules External Library Composer Change
avatar Hackwar Hackwar - change - 6 Jul 2019
The description was changed
avatar Hackwar Hackwar - edited - 6 Jul 2019
avatar Hackwar Hackwar - change - 7 Jul 2019
The description was changed
avatar Hackwar Hackwar - edited - 7 Jul 2019
avatar Hackwar Hackwar - change - 8 Jul 2019
Labels Added: ? ? ?
avatar wilsonge wilsonge - change - 11 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-11 19:21:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Jul 2019
avatar wilsonge wilsonge - merge - 11 Jul 2019

Add a Comment

Login with GitHub to post a comment