J3 Issue ?
avatar n9iels
n9iels
1 Jul 2019

What needs to be fixed

In option=com_templates&view=template the file tree on the left highlights both files as "active" when the names are similar, like menu.less and mmenu.less.

How would you fix it

The root-cause of this issue is the way the active item is set. Currently this happens with a piece of JavaScript and a regex: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_templates/views/template/tmpl/default.php#L91

Either the regex is insufficient or the method of comparison is not the right one.

Side Effects expected

I am not sure why a regex is used here instead of a === or something like that. Maybe there are some unwanted side effects I am not aware of?

avatar n9iels n9iels - open - 1 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Jul 2019
avatar n9iels n9iels - change - 1 Jul 2019
Title
Incorrect active file highlight in com_templates with similar names
Duplicated active file highlight in com_templates with similar names
avatar n9iels n9iels - edited - 1 Jul 2019
avatar n9iels n9iels - change - 1 Jul 2019
The description was changed
avatar n9iels n9iels - edited - 1 Jul 2019
avatar n9iels n9iels - change - 1 Jul 2019
The description was changed
avatar n9iels n9iels - edited - 1 Jul 2019
avatar Quy Quy - change - 1 Jul 2019
Labels Added: J3 Issue
avatar Quy Quy - labeled - 1 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Jul 2019
Status New Discussion
avatar SharkyKZ
SharkyKZ - comment - 2 Jul 2019

Test PR #25399 please.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2019
Closed_By alikon joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 2 Jul 2019
avatar alikon alikon - change - 2 Jul 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-07-02 06:37:31
Closed_By alikon
avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Jul 2019

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/25395

avatar alikon
alikon - comment - 2 Jul 2019

closed for #25399


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25395.

Add a Comment

Login with GitHub to post a comment